Droog71/oolite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed erroneous behaviour when NaN was passed via script for pitch, roll and yaw. Closes #303.

Browse Source
This commit is contained in:
AnotherCommander 2018-07-05 14:57:48 +02:00
parent e1ffdb6516
commit 2de1aea173
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/Core/Scripting/OOJSPlayerShip.m
View File

@ -789,7 +789,10 @@ static JSBool PlayerShipSetProperty(JSContext *context, JSObject *this, jsid pro
case kPlayerShip_pitch:
if (JS_ValueToNumber(context, *value, &fValue))
{
[player decrease_flight_pitch:[player flightPitch] + fValue];
if (!isnan(fValue)) // guard against undefined
{
[player decrease_flight_pitch:[player flightPitch] + fValue];
}
return YES;
}
break;
@ -797,7 +800,10 @@ static JSBool PlayerShipSetProperty(JSContext *context, JSObject *this, jsid pro
case kPlayerShip_roll:
if (JS_ValueToNumber(context, *value, &fValue))
{
[player decrease_flight_roll:[player flightRoll] + fValue];
if (!isnan(fValue)) // guard against undefined
{
[player decrease_flight_roll:[player flightRoll] + fValue];
}
return YES;
}
break;
@ -805,7 +811,10 @@ static JSBool PlayerShipSetProperty(JSContext *context, JSObject *this, jsid pro
case kPlayerShip_yaw:
if (JS_ValueToNumber(context, *value, &fValue))
{
[player decrease_flight_yaw:[player flightYaw] + fValue];
if (!isnan(fValue)) // guard against undefined
{
[player decrease_flight_yaw:[player flightYaw] + fValue];
}
return YES;
}
break;