Commit Graph

295 Commits (2733516cb9cdad7ac4cef98b819d4d01846e5c66)

Author SHA1 Message Date
Leandro Doctors 2733516cb9 Organize imports 2020-01-16 08:21:24 +08:00
Martin Petricek 413a5a2230 Unlimited-number cards (#1593)
* Store list of "can be any times in deck" cards in one central location. Add Rat Colony to the list.

* Add Rat Colony
2018-06-21 10:39:27 +08:00
Ada Joule d213884dc2 Add Saga mechanic (#1564)
* Add AtBeginOfFirstMainPhaseTrigger and adding lore counter to saga

* Make add counter trigger more generic

* Change begin main phase trigger to Saga-specific

* Add magic.data.RomanToInt

* Add chapter parsing to ARG

* Add SagaChapterTrigger

* Add chapter ability to MagicAbility

* Add lore counter mechanic to Saga card definiton

* Add Saga sacrifice state-based action

* Fix import

* Fix getPendingTriggers

* Add History of Benalia

* Fix adding ETB trigger

* Remove AtBeginningOfFirstMainPhaseTrigger.Saga, Add counters directly in MagicMainPhase.executeBeginStep()

* Remove null case from RomanToInt

* Revert "Remove AtBeginningOfFirstMainPhaseTrigger.Saga, Add counters directly in MagicMainPhase.executeBeginStep()"

This reverts commit d8e5d1f253ab7b54f401f4151b44d39ee927f44c.

* Move isSaga method to IRenderableCard
2018-05-04 14:17:55 +08:00
Martin Petricek bd5ae5fd7a Refactoring (#1543)
* Fix typos.

* Remove unnecessary boxing/unboxing.

* Replace traditional 'for' loops with 'foreach' loops.

* Replace explicit types with <> (diamonds) where they can be inferred.

* Collapse identical catch branches.

* Replace statement lambda with expression lambda for short statements.

* Remove unnecessary imports.

* Replace some lambdas with Comparator.comparing

* Replace Runnables with lambdas.

* Use addAll instead of adding whole collection manually.

* Simplify boolean expressions.

* Remove redundant 'else'.

* Simplify some boolean conditions that are always true or false.

* Inline redundant local variables.

* Remove extraneous semicolons.

* Fix Javadoc errors.

* Replace anonymous classes with lambdas.

* Replace chain of 'if's with switch.

* Remove delaration of exception that is never thrown.

* Use String/StringBuilder properly.
2018-04-08 08:59:14 +08:00
melvinzhang 35f423b263 add casting condition to legendary sorceries, closes #1536 2018-04-05 20:21:52 +08:00
melvinzhang fb053f09e2 remove setDefaultHandAct, move adding of hand activation into loadAbilities 2017-08-08 17:39:35 +08:00
melvinzhang 98c28b1f85 move logic for default cast action into MagicCardDefinition 2017-08-08 09:42:44 +08:00
melvinzhang d29d24d626 casting without paying mana cost should be affected by cost modifications 2017-08-08 09:37:25 +08:00
melvinzhang 23f6c887fc add missing override annotation 2017-07-21 18:10:11 +08:00
lodici 3e664f34c4 remove unused methods in MagicCardDefinition. 2017-06-19 12:45:08 +01:00
melvinzhang bbbdcac9ef add override annotation to overridden methods 2017-06-17 11:19:03 +08:00
lodici 9f700df5d5 add sorting comparator as static constant to MagicCardDefinition. 2017-05-05 13:13:53 +01:00
lodici 966caa0f05 fix: need to click twice the first time on name column to trigger sort. 2017-02-04 14:08:13 +00:00
melvinzhang 5d2543cf0b fix token cdef constructor to include abilities, fixes #1040 2017-01-31 21:47:24 +08:00
lodici c6a34ac5d4 support '<card name>.full.jpg' pattern as a custom image file. 2017-01-21 15:49:29 +00:00
ShawnieBoy 6c3c08a055 include locale in toLowerCase() 2016-12-28 00:53:29 +00:00
lodici 79ae406b44 relocate IRenderableCard into magic.model. 2016-10-06 12:26:58 +01:00
lodici b55da6a394 create 'magic.cardDefinition*' and relocate classes. 2016-10-05 13:53:20 +01:00
ShawnieBoy 4911b05d2f prevent adding 'Tribal' to getLongTypeString() addition of supertypes 2016-09-24 16:22:39 +01:00
melvinzhang 8f1977cd24 revert PT setting token to changing of card definition so that it is copied correctly 2016-09-24 13:21:56 +08:00
lodici 6cb85f284a checkboxes creation now handled by FilterButtonPanel instead of sub-classes. 2016-09-02 20:42:02 +01:00
lodici 55c6ec423a Add "unsupported" filter button to explorer (closes #827). 2016-08-29 11:39:59 +01:00
melvinzhang eb8bf6bac2 revert == to equals replacement, shorten param names 2016-07-19 11:59:03 +08:00
ShawnieBoy 77281766b9 tidy MagicCardDefinition 2016-07-18 17:43:17 +01:00
ShawnieBoy 10f4c6f7f9 add card Status to explorer filters 2016-07-18 17:41:46 +01:00
ShawnieBoy d293c0d827 add MELD property to melded products 2016-07-18 13:38:56 +01:00
melvinzhang a065e9e316 add factory method that uses a template card def 2016-06-18 10:07:16 +08:00
ShawnieBoy 88d5bb1e1c rename isCardExemptFromMaxCopiesRestriction()
to canHaveAnyNumberInDeck() and place in MagicCardDefinition
2016-03-26 11:10:02 +00:00
melvinzhang d5579b8ab3 replace tab with four spaces, remove trailing whitespace 2016-02-24 10:04:14 +08:00
neoedmund 88ce4eeb17 fix table sort by rarity :
Mythic_Rare>Rare>Uncommon>Common>Basic>Unknow(token)
add table sort by subtype: string order
2016-02-23 14:02:13 +00:00
lodici a5ef7bc23e When scanning for missing images checks in 'custom', 'crops', 'cards' and 'tokens' folders. 2016-02-04 14:49:20 +00:00
ShawnieBoy c5c635c464 count split cards by physical card, as with transform and flip 2016-02-01 13:19:15 +00:00
ShawnieBoy 32d16ac19f add second_half property for split card order 2016-01-31 16:49:00 +00:00
ShawnieBoy 1b8b58f67c add Split property to identify Split cards for Cardbuilder 2016-01-31 15:06:24 +00:00
lodici ca4827ffe8 remove redundant imageCount from MagicCardDefinition. 2016-01-18 12:12:51 +00:00
ShawnieBoy 6230378e70 rename comeIntoPlayTriggers to etbTriggers 2016-01-10 18:14:09 +00:00
melvinzhang c4efbb9def replace comparison with MagicManaCost.NONE with hasCost 2016-01-07 09:49:10 +08:00
melvinzhang 4d7f8edb2e remove cost and ability from UNKNOWN and make it colorless as it cannot be cast 2016-01-07 09:43:52 +08:00
melvinzhang 164bfecec5 require mana cost only if mana cost is specified, i.e. not NONE, fixes #636 2016-01-07 09:32:44 +08:00
melvinzhang 317f646091 remove methods from MagicCardDefinition that duplicates default method in IRenderableCard 2016-01-06 17:24:01 +08:00
melvinzhang a6830b0786 consolidate duplicate implementations as default methods in IRenderableCard 2016-01-06 14:26:58 +08:00
ShawnieBoy 391e61f570 simplify isHybrid() logic 2016-01-06 03:29:08 +00:00
ShawnieBoy dfd18996f7 generate TypeLine texts using MagicType.TYPE_ORDER 2016-01-06 03:26:16 +00:00
melvinzhang 1fee8d6607 show other side of unimplemented card in card explorer 2016-01-06 11:03:35 +08:00
melvinzhang 7d07fecb67 denote cards with no mana cost using MagicManaCost.NONE, to differentiate those with mana cost {0} 2016-01-06 09:43:19 +08:00
lodici d1b6c8fbc9 refactor cost visibility code check into MagicCardDefinition method. 2016-01-05 22:29:54 +00:00
ShawnieBoy b0dcbdfbf4 correct Type order and condense method 2016-01-05 20:39:43 +00:00
ShawnieBoy 02ac3487b6 add Planeswalker to getTypeString() allowing it to appear in explorer 2016-01-05 20:18:51 +00:00
ShawnieBoy f2c5baf27d return Common for getRarityChar() == null - Tokens have no true rarity
but contain Common rarity symbol
2016-01-05 18:47:25 +00:00
ShawnieBoy 0dc50c65b8 add getRarityChar() to IRenderableCard 2016-01-05 18:14:51 +00:00