Commit Graph

37 Commits (master)

Author SHA1 Message Date
Leandro Doctors 2733516cb9 Organize imports 2020-01-16 08:21:24 +08:00
Martin Petricek bd5ae5fd7a Refactoring (#1543)
* Fix typos.

* Remove unnecessary boxing/unboxing.

* Replace traditional 'for' loops with 'foreach' loops.

* Replace explicit types with <> (diamonds) where they can be inferred.

* Collapse identical catch branches.

* Replace statement lambda with expression lambda for short statements.

* Remove unnecessary imports.

* Replace some lambdas with Comparator.comparing

* Replace Runnables with lambdas.

* Use addAll instead of adding whole collection manually.

* Simplify boolean expressions.

* Remove redundant 'else'.

* Simplify some boolean conditions that are always true or false.

* Inline redundant local variables.

* Remove extraneous semicolons.

* Fix Javadoc errors.

* Replace anonymous classes with lambdas.

* Replace chain of 'if's with switch.

* Remove delaration of exception that is never thrown.

* Use String/StringBuilder properly.
2018-04-08 08:59:14 +08:00
ShawnieBoy b611eaae48 Import reorganise/remove unused 2014-04-18 22:43:01 +01:00
melvin 4b0e21ab95 move getCountersScore into MagicPermanent, improve performance to take time proportional to number of counters on the permanent 2014-03-14 14:14:16 +08:00
melvin 8c00863b21 tokens don't have rarity, include rarity in score only if non token 2014-03-05 22:05:19 +08:00
melvin 9f6f2e9fb8 replace tab with four spaces 2014-02-20 19:58:39 +08:00
melvin cc19af78c3 remove commended out code 2014-02-01 12:29:39 +08:00
ShawnieBoyUK@gmail.com c48b53a051 Amend getAllCountersScore return value 2014-01-28 18:54:45 +00:00
ShawnieBoyUK@gmail.com 6d7ef68b9a Implement Scoring system for CounterTypes 2014-01-28 18:25:18 +00:00
melvin 64368e1b9a remove extraneous whitespace 2013-06-24 09:33:35 +08:00
melvin f1b27c586c convert to UNIX line endings 2013-04-13 10:32:25 +08:00
melvin 3e25833191 call method on MagicPermanent instead of getting MagicCardDefinition 2013-01-20 10:29:40 +08:00
melvin 692d4b234d replace long representation of multiple MagicAbility with Set<MagicAbility> 2013-01-19 17:02:56 +08:00
melvin aa270db22f replace getAllAbilityFlags with getAbilityFlags 2012-10-13 11:30:34 +08:00
melvin 96f3a6161c wrap long lines 2012-10-12 14:52:57 +08:00
melvin fca6114d11 warp long lines 2012-10-12 14:51:29 +08:00
melvin 9864cd3997 replace C style array delcaration with Java style 2012-09-28 16:09:47 +08:00
melvin 631dd73e4b infer final annotation for local variables 2012-09-28 16:04:12 +08:00
melvin c5da1d2a02 convert tab to four spaces 2012-08-26 16:54:43 +08:00
melvin 976aab2c4e change card definition value from int to double 2012-08-09 14:39:49 +08:00
melvin 9f7a5dfd3e removed turn parameter from methods 2012-06-12 09:54:51 +08:00
melvin f369c209de removed unnecessary game parameter from methods 2012-06-03 19:36:56 +08:00
melvin c8aec53ac4 removed unecessary game parameter from methods 2012-06-03 19:13:42 +08:00
melvin c389a6ec86 MagicPermament can refer to the containing MagicGame instance, refactor isCreature to remove the MagicGame parameter 2012-06-03 17:19:02 +08:00
melvin 37fdb107f2 Removed empty lines, added whitespace between operators 2011-11-29 15:49:55 +08:00
beholder 6ad7f715ad added noCastingCost to MagicGraveyardTargetPicker. changed cards to match 2011-09-19 19:07:50 +02:00
melvin 256304a721 added game as argument 2011-09-18 22:48:18 +08:00
melvin 901a62d213 use getCardPower and getCardToughness 2011-09-18 20:07:42 +08:00
melvin 33c3bb9d4b made power and toughness private members of MagicPowerToughness 2011-09-16 11:38:54 +08:00
melvin 57beae6a8e replaced import * with single class import statements 2011-08-31 14:08:53 +08:00
melvin 850d01d3d1 optimized import statements with IntelliJ 2011-08-10 23:28:35 +08:00
melvin 4b82e7e489 wrapped long lines 2011-06-17 14:18:00 +08:00
melvin fa1f2ae0a4 replace getIndex with ordinal 2011-06-16 21:10:13 +08:00
ubeefx 570ed62f81 Improved scoring for equip. 2011-04-10 17:05:22 +00:00
ubeefx 57b6bb3e90 Support for infect keyword and poison counters.
6 infect creature cards.
2011-03-20 21:45:42 +00:00
ubeefx b28d1895f7 Added support for milling and level up.
Added Student of Warfare, Sword of Body and Mind and Szadek, Lord of Secrets.
2010-12-15 23:29:27 +00:00
ubeefx 7fd13965b2 Initial version. 2010-11-21 18:54:59 +00:00