mark members as final

src/magic/data/DownloadCardTextFile.java

@@ -11,7 +11,7 @@ public class DownloadCardTextFile extends WebDownloader {
     private static final String endPattern = "</p>";
     
     private final File file;
-    private URL url;
+    private final URL url;
     
     DownloadCardTextFile(final File file, final URL url) {
         this.file = file;

src/magic/model/MagicCondensedCardDefinition.java

@@ -5,7 +5,7 @@ import java.util.Comparator;
 // basically a wrapper for MagicCardDefinition that adds number of copies of card
 public class MagicCondensedCardDefinition {
     private int copies;
-    private MagicCardDefinition card;
+    private final MagicCardDefinition card;
     
     public MagicCondensedCardDefinition(MagicCardDefinition card) {
         this.card = card;

src/magic/model/MagicGameLog.java

@@ -11,7 +11,7 @@ import java.util.Date;
 
 public class MagicGameLog {
     
-    private static String gameLog = MagicMain.getGamePath() + File.separator + "game.log";
+    private static final String gameLog = MagicMain.getGamePath() + File.separator + "game.log";
     private static PrintWriter writer = null;
     
     private MagicGameLog() {}

src/magic/model/MagicPermanent.java

@@ -85,7 +85,7 @@ public class MagicPermanent implements MagicSource,MagicTarget,Comparable<MagicP
     private MagicPermanent blockedCreature = MagicPermanent.NONE;
     private final MagicPermanentList blockingCreatures;    
     private MagicPermanent pairedCreature = MagicPermanent.NONE;
-    private MagicCardList exiledCards;
+    private final MagicCardList exiledCards;
     private MagicTarget chosenTarget;
     private int counters[]=new int[MagicCounterType.NR_COUNTERS];
     private int stateFlags = 

src/magic/model/choice/MagicTargetChoice.java

@@ -477,7 +477,7 @@ public class MagicTargetChoice extends MagicChoice {
     }
    
 
-    private static Map<String, MagicTargetChoice> factory =
+    private static final Map<String, MagicTargetChoice> factory =
         new HashMap<String, MagicTargetChoice>();
 
     static {

src/magic/model/event/MagicEventActionFactory.java

@@ -14,10 +14,10 @@ import java.util.HashMap;
 import java.util.Map;
 
 public class MagicEventActionFactory {
-    private static Map<String, MagicEventAction> factory = 
+    private static final Map<String, MagicEventAction> factory =
         new HashMap<String, MagicEventAction>();
     
-    private static Map<String, String> hint = 
+    private static final Map<String, String> hint =
         new HashMap<String, String>();
     
     private static void register(String key, MagicEventAction action) {

src/magic/model/mstatic/MagicStatic.java

@@ -21,7 +21,7 @@ public abstract class MagicStatic extends MagicDummyPermanentModifier implements
     //layer where this effect operate
     private final MagicLayer layer;
 
-    private boolean isUntilEOT;
+    private final boolean isUntilEOT;
 
     protected MagicStatic(final MagicLayer aLayer, final MagicTargetFilter aFilter, final boolean aIsUntilEOT) {
         filter = aFilter;

src/magic/model/target/MagicTargetPicker.java

@@ -31,7 +31,7 @@ public abstract class MagicTargetPicker<T> {
         return Collections.singletonList(bestTarget);
     }
     
-    private static Map<String, MagicTargetPicker<MagicPermanent>> factory = 
+    private static final Map<String, MagicTargetPicker<MagicPermanent>> factory =
         new HashMap<String, MagicTargetPicker<MagicPermanent>>();
 
     static {

src/magic/model/trigger/MagicEchoTrigger.java

@@ -13,7 +13,7 @@ import magic.model.event.MagicEvent;
 
 public class MagicEchoTrigger extends MagicAtUpkeepTrigger {
 
-    private MagicManaCost manaCost;
+    private final MagicManaCost manaCost;
     
     public MagicEchoTrigger(final MagicManaCost manaCost) {
         this.manaCost = manaCost;

src/magic/ui/viewer/DeckDescriptionPreview.java

@@ -21,8 +21,8 @@ public class DeckDescriptionPreview extends JComponent implements PropertyChange
     
     File file = null;
     String description;
-    private JTextArea textArea = new JTextArea();
-    private JScrollPane scrollPane = new JScrollPane(textArea);
+    private final JTextArea textArea = new JTextArea();
+    private final JScrollPane scrollPane = new JScrollPane(textArea);
 
     public DeckDescriptionPreview(JFileChooser fc) {
         setPreferredSize(new Dimension(200, 50));