CrazyBaboon
/
MathWorlds
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Shaders: Remove unnecessary 'if' statements 

Pull if GENERATE_NORMALMAPS == 1 into the template to avoid evaluating
it for each fragment.
Remove if (fogDistance != 0.0).
master
Lars Hofhansl 2016-12-07 21:14:18 -08:00 committed by paramat
parent a76e7698b2
commit 923a8f1983
3 changed files with 46 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
client/shaders/nodes_shader/opengl_fragment.glsl
View File

@ -163,7 +163,8 @@ void main(void)
} }
#endif #endif
if (GENERATE_NORMALMAPS == 1 && normalTexturePresent == false) { #if GENERATE_NORMALMAPS == 1
if (normalTexturePresent == false) {
float tl = get_rgb_height(vec2(uv.x - SAMPLE_STEP, uv.y + SAMPLE_STEP)); float tl = get_rgb_height(vec2(uv.x - SAMPLE_STEP, uv.y + SAMPLE_STEP));
float t = get_rgb_height(vec2(uv.x - SAMPLE_STEP, uv.y - SAMPLE_STEP)); float t = get_rgb_height(vec2(uv.x - SAMPLE_STEP, uv.y - SAMPLE_STEP));
float tr = get_rgb_height(vec2(uv.x + SAMPLE_STEP, uv.y + SAMPLE_STEP)); float tr = get_rgb_height(vec2(uv.x + SAMPLE_STEP, uv.y + SAMPLE_STEP));
@ -177,7 +178,7 @@ void main(void)
bump = vec4(normalize(vec3 (dX, dY, NORMALMAPS_STRENGTH)), 1.0); bump = vec4(normalize(vec3 (dX, dY, NORMALMAPS_STRENGTH)), 1.0);
use_normalmap = true; use_normalmap = true;
} }
#endif
vec4 base = texture2D(baseTexture, uv).rgba; vec4 base = texture2D(baseTexture, uv).rgba;
#ifdef ENABLE_BUMPMAPPING #ifdef ENABLE_BUMPMAPPING
@ -200,20 +201,18 @@ void main(void)
col = applyToneMapping(col); col = applyToneMapping(col);
#endif #endif
if (fogDistance != 0.0) { // Due to a bug in some (older ?) graphics stacks (possibly in the glsl compiler ?),
// Due to a bug in some (older ?) graphics stacks (possibly in the glsl compiler ?), // the fog will only be rendered correctly if the last operation before the
// the fog will only be rendered correctly if the last operation before the // clamp() is an addition. Else, the clamp() seems to be ignored.
// clamp() is an addition. Else, the clamp() seems to be ignored. // E.g. the following won't work:
// E.g. the following won't work: // float clarity = clamp(fogShadingParameter
// float clarity = clamp(fogShadingParameter // * (fogDistance - length(eyeVec)) / fogDistance), 0.0, 1.0);
// * (fogDistance - length(eyeVec)) / fogDistance), 0.0, 1.0); // As additions usually come for free following a multiplication, the new formula
// As additions usually come for free following a multiplication, the new formula // should be more efficient as well.
// should be more efficient as well. // Note: clarity = (1 - fogginess)
// Note: clarity = (1 - fogginess) float clarity = clamp(fogShadingParameter
float clarity = clamp(fogShadingParameter - fogShadingParameter * length(eyeVec) / fogDistance, 0.0, 1.0);
- fogShadingParameter * length(eyeVec) / fogDistance, 0.0, 1.0); col = mix(skyBgColor, col, clarity);
col = mix(skyBgColor, col, clarity);
}
col = vec4(col.rgb, base.a); col = vec4(col.rgb, base.a);
gl_FragColor = col; gl_FragColor = col;

30
client/shaders/water_surface_shader/opengl_fragment.glsl
View File

@ -114,7 +114,8 @@ void main(void)
} }
#endif #endif
if (GENERATE_NORMALMAPS == 1 && use_normalmap == false) { #if GENERATE_NORMALMAPS == 1
if (use_normalmap == false) {
float tl = get_rgb_height (vec2(uv.x-SAMPLE_STEP,uv.y+SAMPLE_STEP)); float tl = get_rgb_height (vec2(uv.x-SAMPLE_STEP,uv.y+SAMPLE_STEP));
float t = get_rgb_height (vec2(uv.x-SAMPLE_STEP,uv.y-SAMPLE_STEP)); float t = get_rgb_height (vec2(uv.x-SAMPLE_STEP,uv.y-SAMPLE_STEP));
float tr = get_rgb_height (vec2(uv.x+SAMPLE_STEP,uv.y+SAMPLE_STEP)); float tr = get_rgb_height (vec2(uv.x+SAMPLE_STEP,uv.y+SAMPLE_STEP));
@ -128,6 +129,7 @@ void main(void)
bump = vec4 (normalize(vec3 (dX, -dY, NORMALMAPS_STRENGTH)),1.0); bump = vec4 (normalize(vec3 (dX, -dY, NORMALMAPS_STRENGTH)),1.0);
use_normalmap = true; use_normalmap = true;
} }
#endif
vec4 base = texture2D(baseTexture, uv).rgba; vec4 base = texture2D(baseTexture, uv).rgba;
@ -156,20 +158,18 @@ vec4 base = texture2D(baseTexture, uv).rgba;
col = applyToneMapping(col); col = applyToneMapping(col);
#endif #endif
if (fogDistance != 0.0) { // Due to a bug in some (older ?) graphics stacks (possibly in the glsl compiler ?),
// Due to a bug in some (older ?) graphics stacks (possibly in the glsl compiler ?), // the fog will only be rendered correctly if the last operation before the
// the fog will only be rendered correctly if the last operation before the // clamp() is an addition. Else, the clamp() seems to be ignored.
// clamp() is an addition. Else, the clamp() seems to be ignored. // E.g. the following won't work:
// E.g. the following won't work: // float clarity = clamp(fogShadingParameter
// float clarity = clamp(fogShadingParameter // * (fogDistance - length(eyeVec)) / fogDistance), 0.0, 1.0);
// * (fogDistance - length(eyeVec)) / fogDistance), 0.0, 1.0); // As additions usually come for free following a multiplication, the new formula
// As additions usually come for free following a multiplication, the new formula // should be more efficient as well.
// should be more efficient as well. // Note: clarity = (1 - fogginess)
// Note: clarity = (1 - fogginess) float clarity = clamp(fogShadingParameter
float clarity = clamp(fogShadingParameter - fogShadingParameter * length(eyeVec) / fogDistance, 0.0, 1.0);
- fogShadingParameter * length(eyeVec) / fogDistance, 0.0, 1.0); col = mix(skyBgColor, col, clarity);
col = mix(skyBgColor, col, clarity);
}
col = vec4(col.rgb, base.a); col = vec4(col.rgb, base.a);
gl_FragColor = col; gl_FragColor = col;

31
client/shaders/wielded_shader/opengl_fragment.glsl
View File

@ -75,7 +75,8 @@ void main(void)
} }
#endif #endif
if (GENERATE_NORMALMAPS == 1 && normalTexturePresent == false) { #if GENERATE_NORMALMAPS == 1
if (normalTexturePresent == false) {
float tl = get_rgb_height(vec2(uv.x - SAMPLE_STEP, uv.y + SAMPLE_STEP)); float tl = get_rgb_height(vec2(uv.x - SAMPLE_STEP, uv.y + SAMPLE_STEP));
float t = get_rgb_height(vec2(uv.x - SAMPLE_STEP, uv.y - SAMPLE_STEP)); float t = get_rgb_height(vec2(uv.x - SAMPLE_STEP, uv.y - SAMPLE_STEP));
float tr = get_rgb_height(vec2(uv.x + SAMPLE_STEP, uv.y + SAMPLE_STEP)); float tr = get_rgb_height(vec2(uv.x + SAMPLE_STEP, uv.y + SAMPLE_STEP));
@ -89,6 +90,7 @@ void main(void)
bump = vec4(normalize(vec3 (dX, dY, NORMALMAPS_STRENGTH)), 1.0); bump = vec4(normalize(vec3 (dX, dY, NORMALMAPS_STRENGTH)), 1.0);
use_normalmap = true; use_normalmap = true;
} }
#endif
vec4 base = texture2D(baseTexture, uv).rgba; vec4 base = texture2D(baseTexture, uv).rgba;
@ -108,19 +110,18 @@ void main(void)
vec4 col = vec4(color.rgb, base.a); vec4 col = vec4(color.rgb, base.a);
col *= gl_Color; col *= gl_Color;
if (fogDistance != 0.0) { // Due to a bug in some (older ?) graphics stacks (possibly in the glsl compiler ?),
// Due to a bug in some (older ?) graphics stacks (possibly in the glsl compiler ?), // the fog will only be rendered correctly if the last operation before the
// the fog will only be rendered correctly if the last operation before the // clamp() is an addition. Else, the clamp() seems to be ignored.
// clamp() is an addition. Else, the clamp() seems to be ignored. // E.g. the following won't work:
// E.g. the following won't work: // float clarity = clamp(fogShadingParameter
// float clarity = clamp(fogShadingParameter // * (fogDistance - length(eyeVec)) / fogDistance), 0.0, 1.0);
// * (fogDistance - length(eyeVec)) / fogDistance), 0.0, 1.0); // As additions usually come for free following a multiplication, the new formula
// As additions usually come for free following a multiplication, the new formula // should be more efficient as well.
// should be more efficient as well. // Note: clarity = (1 - fogginess)
// Note: clarity = (1 - fogginess) float clarity = clamp(fogShadingParameter
float clarity = clamp(fogShadingParameter - fogShadingParameter * length(eyeVec) / fogDistance, 0.0, 1.0);
- fogShadingParameter * length(eyeVec) / fogDistance, 0.0, 1.0); col = mix(skyBgColor, col, clarity);
col = mix(skyBgColor, col, clarity);
}
gl_FragColor = vec4(col.rgb, base.a); gl_FragColor = vec4(col.rgb, base.a);
} }