From 41b79398a3352f846cf298c7a223ac767a80dcb2 Mon Sep 17 00:00:00 2001 From: renu555 Date: Wed, 2 Jul 2014 14:33:37 +0530 Subject: [PATCH] Always true condition. for (int index = 0; index < size && !isMultiLine; ++index) In addition to dead code, in the above if condition checking to !isMultiLine is of no use as it will be always true and hence "for" depends only on condition [index < size.] The mentioned test case works fine in this case also. --- src/lib_json/json_writer.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib_json/json_writer.cpp b/src/lib_json/json_writer.cpp index 52f6e21..52ecf3e 100644 --- a/src/lib_json/json_writer.cpp +++ b/src/lib_json/json_writer.cpp @@ -341,7 +341,7 @@ bool StyledWriter::isMultineArray(const Value &value) { childValues_.reserve(size); addChildValues_ = true; int lineLength = 4 + (size - 1) * 2; // '[ ' + ', '*n + ' ]' - for (int index = 0; index < size && !isMultiLine; ++index) { + for (int index = 0; index < size; ++index) { writeValue(value[index]); lineLength += int(childValues_[index].length()); } @@ -564,7 +564,7 @@ bool StyledStreamWriter::isMultineArray(const Value &value) { childValues_.reserve(size); addChildValues_ = true; int lineLength = 4 + (size - 1) * 2; // '[ ' + ', '*n + ' ]' - for (int index = 0; index < size && !isMultiLine; ++index) { + for (int index = 0; index < size; ++index) { writeValue(value[index]); lineLength += int(childValues_[index].length()); }