From bce2e17a43eebd93e9884343978c7ffeaf825e79 Mon Sep 17 00:00:00 2001
From: Juraj Vajda <juraj.vajda@gmail.com>
Date: Wed, 17 Oct 2018 20:51:35 -0400
Subject: [PATCH] sneak hides nametag and removes footstep sound

---
 item_drop.lua | 80 ++++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 60 insertions(+), 20 deletions(-)

diff --git a/item_drop.lua b/item_drop.lua
index e2a69b0..35b6d6f 100644
--- a/item_drop.lua
+++ b/item_drop.lua
@@ -4,27 +4,67 @@ item_drop_settings.radius_magnet         = 2.5 --radius of item magnet
 item_drop_settings.radius_collect        = 0.4 --radius of collection
 item_drop_settings.player_collect_height = 1.5 --added to their pos y value
 local delay = 0
+local timer = 0
+
+local sneak = {}
+
+minetest.register_on_joinplayer(function(player)
+	local player_name = player:get_player_name()
+	sneak[player_name] = false
+end)
+
+minetest.register_on_leaveplayer(function(player)
+	local player_name = player:get_player_name()
+	sneak[player_name] = nil
+end)
 
 minetest.register_globalstep(function(dtime)
-	for _,player in ipairs(minetest.get_connected_players()) do
-		if player:get_player_control().sneak and (player:get_hp() > 0 or not minetest.settings:get_bool("enable_damage")) then
+	timer = timer + dtime
+
+	-- every 1 second
+	if timer >= 1 then
+		for _, player in ipairs(minetest.get_connected_players()) do
+			local control = player:get_player_control()
+			local player_hp = player:get_hp()
+			local player_name = player:get_player_name()
+
+			if control.sneak and (player_hp > 0 or not minetest.settings:get_bool("enable_damage")) then
+
+				-- [Shift + E + Q] single drop item
+				-- autopickup after delay
+				if control.aux1 then
+					delay = 3
+				end
+
+				if delay > 0 then
+					minetest.after(delay, function()
+						delay = 0
+					end)
+					return
+				else
+					pick_dropped_items(player)
+				end
 
-			-- [Shift + E + Q] single drop item
-			-- autopickup after delay
-			if player:get_player_control().aux1 then
-				delay = 2
 			end
 
-			if delay > 0 then
-				minetest.after(delay, function()
-					delay = 0
-				end)
-				return
-			else
-				pick_dropped_items(player)
+			-- hide nametag when sneaking
+			if control.sneak ~= sneak[player_name] then
+				if control.sneak and player_hp > 0 then
+					local nametag_tbl = player:get_nametag_attributes()
+					nametag_tbl.color.a = 0
+					player:set_nametag_attributes(nametag_tbl)
+					player:set_properties{makes_footstep_sound = false}
+				else
+					local nametag_tbl = player:get_nametag_attributes()
+					nametag_tbl.color.a = 255
+					player:set_nametag_attributes(nametag_tbl)
+					player:set_properties{makes_footstep_sound = true}
+				end
+				sneak[player_name] = control.sneak
 			end
-
 		end
+
+		timer = 0
 	end
 end)
 
@@ -49,16 +89,16 @@ function pick_dropped_items(player)
 			end
 		end
 	end
-	
+
 	--magnet
 	for _,object in ipairs(minetest.get_objects_inside_radius({x=pos.x,y=pos.y + item_drop_settings.player_collect_height,z=pos.z}, item_drop_settings.radius_magnet)) do
 		if not object:is_player() and object:get_luaentity() and object:get_luaentity().name == "__builtin:item" then
 
 			object:get_luaentity().collect = true
-			
+
 			if object:get_luaentity().collect then
 				if inv and inv:room_for_item("main", ItemStack(object:get_luaentity().itemstring)) then
-					
+
 					local pos1 = pos
 					pos1.y = pos1.y+0.2
 					local pos2 = object:getpos()
@@ -68,12 +108,12 @@ function pick_dropped_items(player)
 					vec.y = pos2.y + vec.y
 					vec.z = pos2.z + vec.z
 					object:moveto(vec)
-				
+
 					object:get_luaentity().physical_state = false
 					object:get_luaentity().object:set_properties({
 						physical = false
 					})
-					
+
 					object:setacceleration({x=0, y=0, z=0})
 					object:setvelocity({x=0, y=0, z=0})
 
@@ -107,7 +147,7 @@ function pick_dropped_items(player)
 							})
 						end
 					end, {player, object})
-					
+
 				end
 			end
 		end