From 62f91509407ee97e258f5ea0431273d09c378c36 Mon Sep 17 00:00:00 2001
From: mckaygerhard <mckaygerhard@gmail.com>
Date: Sun, 13 Aug 2023 18:46:01 -0400
Subject: [PATCH] player_Api - dinamically set the model player on client
 conection

* improves previous commit 13cd243a031ca6c52457032e0bffc8576b549b3a ,
  the problem is that both server and client must be equal protocol, so
  this ugly hack check if this was loaded into FinalMinetest or Multicraft
  to dinamically check client nature and re-registering the model when
  server and client do not have same player models due the colisionbox check
* NOTE: the check already need to check if the engine is old and the server not,
  so the conditional just try to do exact check agains TRUE boolean.
* Closed https://codeberg.org/minenux/minetest-game-minetest/issues/12
  fixed the problem of collisionbox for the lufix player in ugly way but
  much more effectivelly due can be mixed in FinalMinetest and Multicraft
---
 mods/player_api/api.lua  | 64 ++++++++++++++++++++++++++++++++++------
 mods/player_api/init.lua |  6 +++-
 2 files changed, 60 insertions(+), 10 deletions(-)

diff --git a/mods/player_api/api.lua b/mods/player_api/api.lua
index f9a0c30..522aca9 100644
--- a/mods/player_api/api.lua
+++ b/mods/player_api/api.lua
@@ -6,17 +6,63 @@ player_api = {}
 -- Player animation blending
 -- Note: This is currently broken due to a bug in Irrlicht, leave at 0
 local animation_blend = 0
-local player_api.modelchar
-local player_api.eyeheithg
+
+player_api.modelchar = "character.b3d"
+player_api.eyeheithg = 1.5
+player_api.collsibox = {-0.3, 0.0, -0.3, 0.3, 1.7, 0.3}
 
 local is_50 = minetest.has_feature("object_use_texture_alpha") or nil
 
-if is_50 then
-	player_api.modelchar = "character50.b3d"
-	player_api.eyeheithg = 1.47
-else
-	player_api.modelchar = "character40.b3d"
-	player_api.eyeheithg = 1.625
+function  player_api.dynamicmodel(player_name)
+
+	if not player_name then
+		if is_50 then
+			player_api.modelchar = "character50.b3d"
+			player_api.eyeheithg = 1.625
+		else
+			player_api.modelchar = "character40.b3d"
+			player_api.eyeheithg = 1.47
+		end
+		return
+	end
+
+	local engineold = is_50
+	local info = minetest.get_player_information(player_name)
+	-- ugly hack due mixed protocols:
+	if info then
+		local test = info.version_string or "5.0"
+		if test:find("0.4.") or test:find("4.0.")  or test:find("4.1.") then
+			engineold = true
+			player_api.modelchar = "character40.b3d"
+			player_api.eyeheithg = 1.47
+			player_api.collsibox = {-0.3, 0.0, -0.3, 0.3, 1.7, 0.3}
+		else
+			engineold = false
+			player_api.modelchar = "character50.b3d"
+			player_api.eyeheithg = 1.625
+			player_api.collsibox = {-0.3, 0.0, -0.3, 0.3, 1.7, 0.3}
+		end
+		-- only refix register model when protocols are mixed, will slow down server
+		if engineold == true and is_50 == true then
+			minetest.log("warning", "[default/player_api] performance impact: mixed protocols DETECTED on player .. "..player_name.." doin re-register model hack")
+			player_api.register_model( player_api.modelchar, {
+				animation_speed = 30,
+				textures = {"character.png", },
+				animations = {
+					-- Standard animations.
+					stand     = {x = 0,   y = 79},
+					lay       = {x = 162, y = 166},
+					walk      = {x = 168, y = 187},
+					mine      = {x = 189, y = 198},
+					walk_mine = {x = 200, y = 219},
+					sit       = {x = 81,  y = 160},
+				},
+				collisionbox = player_api.collsibox,
+				stepheight = 0.6,
+				eye_height = eyeheithg,
+			})
+		end
+	end
 end
 
 player_api.registered_models = { }
@@ -67,7 +113,7 @@ function player_api.set_model(player, model_name)
 			textures = {"player.png", "player_back.png"},
 			visual = "upright_sprite",
 			visual_size = {x = 1, y = 2},
-			collisionbox = {-0.3, 0.0, -0.3, 0.3, 1.75, 0.3},
+			collisionbox = player_api.collsibox,
 			stepheight = 0.6,
 			eye_height = player_api.eyeheithg,
 		})
diff --git a/mods/player_api/init.lua b/mods/player_api/init.lua
index f3e3ccc..ef30f90 100644
--- a/mods/player_api/init.lua
+++ b/mods/player_api/init.lua
@@ -2,6 +2,8 @@
 
 dofile(minetest.get_modpath("player_api") .. "/api.lua")
 
+player_api.dynamicmodel(nil)
+
 -- Default player appearance
 player_api.register_model(player_api.modelchar, {
 	animation_speed = 30,
@@ -22,7 +24,9 @@ player_api.register_model(player_api.modelchar, {
 
 -- Update appearance when the player joins
 minetest.register_on_joinplayer(function(player)
-	player_api.player_attached[player:get_player_name()] = false
+	local player_name = player:get_player_name()
+	player_api.dynamicmodel(player_name)
+	player_api.player_attached[player_name] = false
 	player_api.set_model(player, player_api.modelchar)
 	player:set_local_animation(
 		{x = 0,   y = 79},