From ff58d35df31e9a677c3d2db9d0715ce886697785 Mon Sep 17 00:00:00 2001 From: Ryan Foster Date: Fri, 20 May 2022 20:51:59 -0400 Subject: [PATCH] decklink-output-ui: Fix crash when stopping preview Removing the first call to `video_output_stop` prevents the `data_mutex` field in `struct video_output` from being destroyed while still in use. The `render_preview_source` function will call `video_output_lock_frame` upon that mutex and encounter a NULL pointer exception. Co-authored-by: Paul Hindt --- UI/frontend-plugins/decklink-output-ui/decklink-ui-main.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/UI/frontend-plugins/decklink-output-ui/decklink-ui-main.cpp b/UI/frontend-plugins/decklink-output-ui/decklink-ui-main.cpp index 6e42fbbe9..a0ef6ec45 100644 --- a/UI/frontend-plugins/decklink-output-ui/decklink-ui-main.cpp +++ b/UI/frontend-plugins/decklink-output-ui/decklink-ui-main.cpp @@ -124,7 +124,6 @@ void preview_output_stop() { obs_output_stop(context.output); obs_output_release(context.output); - video_output_stop(context.video_queue); obs_remove_main_render_callback(render_preview_source, &context); obs_frontend_remove_event_callback(on_preview_scene_changed, &context);