From 59ed4131a82ab6f526c396e6ecd64cf5c075f617 Mon Sep 17 00:00:00 2001 From: Warchamp7 Date: Tue, 17 Aug 2021 01:41:57 -0400 Subject: [PATCH 01/12] UI: Clean up Settings form markup This continues work from #5133 to correct UI file markup and save correctly in Qt Creator Defining alignment as an attribute in the tag seems to be old behaviour that current versions of Qt Creator do not respect and will clobber these entries on save. The correct approach is to have alignment as a property element in the widget. As well, QWidgets that contain property definitions as well as a layout child item do not properly show up in the Qt Creator hierarchy. These properties are still invisibly applied but the QWidgets are not shown in Qt Creator and will get removed from the file after saving. --- UI/forms/OBSBasicSettings.ui | 52 ++++++++++++++++++------------------ 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/UI/forms/OBSBasicSettings.ui b/UI/forms/OBSBasicSettings.ui index 7a276d301..26e9e7529 100644 --- a/UI/forms/OBSBasicSettings.ui +++ b/UI/forms/OBSBasicSettings.ui @@ -168,8 +168,8 @@ 9 - - + + @@ -799,7 +799,7 @@ 0 - + 0 @@ -824,7 +824,7 @@ - + 0 @@ -1052,7 +1052,7 @@ - + 0 @@ -1196,7 +1196,7 @@ - + 0 @@ -1365,8 +1365,8 @@ 9 - - + + 0 @@ -1882,8 +1882,8 @@ - - + + 0 @@ -1941,8 +1941,8 @@ 9 - - + + 0 @@ -1960,7 +1960,7 @@ 0 - + 0 @@ -1991,7 +1991,7 @@ - + 0 @@ -2124,7 +2124,7 @@ 9 - + QFormLayout::AllNonFixedFieldsGrow @@ -2194,7 +2194,7 @@ 0 - + 0 @@ -2348,7 +2348,7 @@ - + 0 @@ -2518,8 +2518,8 @@ - - + + 0 @@ -2873,7 +2873,7 @@ - + 0 @@ -3010,8 +3010,8 @@ 0 - - + + 0 @@ -3874,8 +3874,8 @@ 9 - - + + @@ -4731,7 +4731,7 @@ 9 - + @@ -5124,7 +5124,7 @@ - + true From 47e370682ba2c055521bdd45eae685e050e3b289 Mon Sep 17 00:00:00 2001 From: Warchamp7 Date: Tue, 17 Aug 2021 01:49:20 -0400 Subject: [PATCH 02/12] UI: Clean up toolbar form markup --- UI/forms/source-toolbar/game-capture-toolbar.ui | 2 +- UI/forms/source-toolbar/text-source-toolbar.ui | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/UI/forms/source-toolbar/game-capture-toolbar.ui b/UI/forms/source-toolbar/game-capture-toolbar.ui index 2a2ea7f0e..e6f0f1851 100644 --- a/UI/forms/source-toolbar/game-capture-toolbar.ui +++ b/UI/forms/source-toolbar/game-capture-toolbar.ui @@ -148,7 +148,7 @@ - + 0 diff --git a/UI/forms/source-toolbar/text-source-toolbar.ui b/UI/forms/source-toolbar/text-source-toolbar.ui index 4c78eb2cd..8c0d62c92 100644 --- a/UI/forms/source-toolbar/text-source-toolbar.ui +++ b/UI/forms/source-toolbar/text-source-toolbar.ui @@ -83,7 +83,7 @@ - + 0 From 3b52bbad61b35c814254c08a3c7a383d4f1f026d Mon Sep 17 00:00:00 2001 From: Warchamp7 Date: Tue, 17 Aug 2021 02:08:08 -0400 Subject: [PATCH 03/12] UI: Clean up AutoConfig form markup --- UI/forms/AutoConfigStreamPage.ui | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UI/forms/AutoConfigStreamPage.ui b/UI/forms/AutoConfigStreamPage.ui index 3ea83e9db..51220f214 100644 --- a/UI/forms/AutoConfigStreamPage.ui +++ b/UI/forms/AutoConfigStreamPage.ui @@ -30,7 +30,7 @@ 0 - + 0 @@ -74,7 +74,7 @@ - + 0 @@ -286,7 +286,7 @@ - + 0 From 092d03afd557256a9a4cdaf5368b862cad3560a8 Mon Sep 17 00:00:00 2001 From: Warchamp7 Date: Tue, 17 Aug 2021 02:08:28 -0400 Subject: [PATCH 04/12] UI: Clean up About form markup --- UI/forms/OBSAbout.ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UI/forms/OBSAbout.ui b/UI/forms/OBSAbout.ui index 9a74cff15..d7e1946cf 100644 --- a/UI/forms/OBSAbout.ui +++ b/UI/forms/OBSAbout.ui @@ -149,7 +149,7 @@ - + 0 From c4edb9a07f886ecf85a8c006cac1fd736031de6f Mon Sep 17 00:00:00 2001 From: Warchamp7 Date: Tue, 17 Aug 2021 04:23:08 -0400 Subject: [PATCH 05/12] UI: Clean up Filters form markup Fixes some QWidgets that Qt Creator tries to clobber. As a result, there are a couple spacers added now for the toolbars to align properly and a stretch policy on the main layout. This re-adds the native attribute for the OBSQTDisplay that was removed in #3782. I believe this particular removal was an error, and there is no way around this entry being native since OBSQTDisplay extends QWidget --- UI/forms/OBSBasicFilters.ui | 135 ++++++++++++++++++++++++------------ 1 file changed, 89 insertions(+), 46 deletions(-) diff --git a/UI/forms/OBSBasicFilters.ui b/UI/forms/OBSBasicFilters.ui index a007df771..7f8401e40 100644 --- a/UI/forms/OBSBasicFilters.ui +++ b/UI/forms/OBSBasicFilters.ui @@ -15,20 +15,26 @@ - + QLayout::SetMinimumSize - + 0 0 + + + 255 + 0 + + 0 @@ -62,8 +68,8 @@ - - + + 4 @@ -88,11 +94,14 @@ 22 + + Add + - + :/res/images/add.png:/res/images/add.png @@ -104,9 +113,6 @@ addIconSmall - - Add - @@ -117,11 +123,14 @@ 22 + + Remove + - + :/res/images/list_remove.png:/res/images/list_remove.png @@ -133,9 +142,6 @@ removeIconSmall - - Remove - @@ -146,11 +152,14 @@ 22 + + MoveUp + - + :/res/images/up.png:/res/images/up.png @@ -162,9 +171,6 @@ upArrowIconSmall - - MoveUp - @@ -175,11 +181,14 @@ 22 + + MoveDown + - + :/res/images/down.png:/res/images/down.png @@ -191,11 +200,24 @@ downArrowIconSmall - - MoveDown - + + + + Qt::Horizontal + + + QSizePolicy::Expanding + + + + 20 + 0 + + + + @@ -210,13 +232,19 @@ - + 0 0 + + + 255 + 0 + + 0 @@ -250,8 +278,8 @@ - - + + 4 @@ -276,11 +304,14 @@ 22 + + Add + - + :/res/images/add.png:/res/images/add.png @@ -292,9 +323,6 @@ addIconSmall - - Add - @@ -305,11 +333,14 @@ 22 + + Remove + - + :/res/images/list_remove.png:/res/images/list_remove.png @@ -321,9 +352,6 @@ removeIconSmall - - Remove - @@ -334,11 +362,14 @@ 22 + + MoveUp + - + :/res/images/up.png:/res/images/up.png @@ -350,9 +381,6 @@ upArrowIconSmall - - MoveUp - @@ -363,11 +391,14 @@ 22 + + MoveDown + - + :/res/images/down.png:/res/images/down.png @@ -379,11 +410,24 @@ downArrowIconSmall - - MoveDown - + + + + Qt::Horizontal + + + QSizePolicy::Expanding + + + + 20 + 0 + + + + @@ -397,7 +441,7 @@ - + 0 @@ -438,7 +482,7 @@ - QDialogButtonBox::Reset|QDialogButtonBox::Close + QDialogButtonBox::Close|QDialogButtonBox::Reset @@ -451,7 +495,7 @@ - + :/res/images/list_remove.png:/res/images/list_remove.png @@ -463,7 +507,7 @@ - + :/res/images/up.png:/res/images/up.png @@ -475,7 +519,7 @@ - + :/res/images/down.png:/res/images/down.png @@ -502,6 +546,5 @@ - - + From 592e404df5061a89e8159390e940e31206014c59 Mon Sep 17 00:00:00 2001 From: Warchamp7 Date: Tue, 17 Aug 2021 04:25:20 -0400 Subject: [PATCH 06/12] UI: Clean up Interact form markup This re-adds the native attribute for the OBSQTDisplay that was removed in #3782. I believe this particular removal was an error, and there is no way around this entry being native since OBSQTDisplay extends QWidget --- UI/forms/OBSBasicInteraction.ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UI/forms/OBSBasicInteraction.ui b/UI/forms/OBSBasicInteraction.ui index e40b64835..65d313bc9 100644 --- a/UI/forms/OBSBasicInteraction.ui +++ b/UI/forms/OBSBasicInteraction.ui @@ -18,7 +18,7 @@ - + 0 From 2233e3450d4d4dbe01e504385f8afb97adea2928 Mon Sep 17 00:00:00 2001 From: Warchamp7 Date: Tue, 17 Aug 2021 05:38:23 -0400 Subject: [PATCH 07/12] UI: Clean up Transform form markup Fixes some QWidgets that Qt Creator tries to clobber. As a result, there is a new spacer added now to ensure the controls remain grouped at the top of the window. --- UI/forms/OBSBasicTransform.ui | 145 ++++++++++++++++++++-------------- 1 file changed, 84 insertions(+), 61 deletions(-) diff --git a/UI/forms/OBSBasicTransform.ui b/UI/forms/OBSBasicTransform.ui index 5a8f834d7..f9b76d501 100644 --- a/UI/forms/OBSBasicTransform.ui +++ b/UI/forms/OBSBasicTransform.ui @@ -7,13 +7,13 @@ 0 0 564 - 241 + 313 Basic.TransformWindow - + @@ -36,10 +36,10 @@ 0 - + Basic.TransformWindow.Position - + Basic.TransformWindow.Position @@ -48,7 +48,7 @@ - + 0 @@ -76,6 +76,9 @@ 0 + + Basic.TransformWindow.PositionX + 4 @@ -85,9 +88,6 @@ 90001.000000000000000 - - Basic.TransformWindow.PositionX - @@ -98,6 +98,9 @@ 0 + + Basic.TransformWindow.PositionY + 4 @@ -107,9 +110,6 @@ 90001.000000000000000 - - Basic.TransformWindow.PositionY - @@ -117,10 +117,10 @@ - + Basic.TransformWindow.Rotation - + Basic.TransformWindow.Rotation @@ -139,6 +139,9 @@ 0 + + Basic.TransformWindow.Rotation + -360.000000000000000 @@ -148,23 +151,20 @@ 0.100000000000000 - - Basic.TransformWindow.Rotation - - + Basic.TransformWindow.Size - + Basic.TransformWindow.Size - + 0 @@ -192,6 +192,9 @@ 0 + + Basic.TransformWindow.Width + 4 @@ -204,9 +207,6 @@ 1.000000000000000 - - Basic.TransformWindow.Width - @@ -217,6 +217,9 @@ 0 + + Basic.TransformWindow.Height + 4 @@ -229,9 +232,6 @@ 1.000000000000000 - - Basic.TransformWindow.Height - @@ -239,22 +239,22 @@ - + Basic.TransformWindow.Alignment - + Basic.TransformWindow.Alignment - - Basic.TransformWindow.Alignment.TopLeft - Basic.TransformWindow.Alignment + + Basic.TransformWindow.Alignment.TopLeft + Basic.TransformWindow.Alignment.TopLeft @@ -317,10 +317,10 @@ - + Basic.TransformWindow.BoundsType - + Basic.TransformWindow.BoundsType @@ -369,10 +369,10 @@ - + Basic.TransformWindow.BoundsAlignment - + Basic.TransformWindow.BoundsAlignment @@ -382,12 +382,12 @@ false - - Basic.TransformWindow.Alignment.TopLeft - Basic.TransformWindow.BoundsAlignment + + Basic.TransformWindow.Alignment.TopLeft + Basic.TransformWindow.Alignment.TopLeft @@ -437,16 +437,16 @@ - + Basic.TransformWindow.Bounds - + Basic.TransformWindow.Bounds - + 0 @@ -477,6 +477,9 @@ 0 + + Basic.TransformWindow.BoundsWidth + 4 @@ -486,9 +489,6 @@ 90001.000000000000000 - - Basic.TransformWindow.BoundsWidth - @@ -502,6 +502,9 @@ 0 + + Basic.TransformWindow.BoundsHeight + 4 @@ -511,9 +514,6 @@ 90001.000000000000000 - - Basic.TransformWindow.BoundsHeight - @@ -534,10 +534,10 @@ - + Basic.TransformWindow.Crop - + Basic.TransformWindow.Crop @@ -558,12 +558,12 @@ 0 - - 100000 - Basic.TransformWindow.CropLeft + + 100000 + @@ -580,12 +580,12 @@ 0 - - 100000 - Basic.TransformWindow.CropRight + + 100000 + @@ -628,12 +628,12 @@ 0 - - 100000 - Basic.TransformWindow.CropTop + + 100000 + @@ -650,12 +650,12 @@ 0 - - 100000 - Basic.TransformWindow.CropBottom + + 100000 + @@ -701,10 +701,23 @@ + + + + Qt::Vertical + + + + 0 + 10 + + + + - QDialogButtonBox::Reset|QDialogButtonBox::Close + QDialogButtonBox::Close|QDialogButtonBox::Reset @@ -717,6 +730,16 @@ rejected() OBSBasicTransform reject() + + + 20 + 20 + + + 20 + 20 + + From 1d48fc0a0eb525a6bdff88c16dbaa390847f6d1d Mon Sep 17 00:00:00 2001 From: Warchamp7 Date: Tue, 17 Aug 2021 05:41:30 -0400 Subject: [PATCH 08/12] UI: Clean up Custom Browser Docks form markup Minor alphabetical rearrange by Qt Creator --- UI/forms/OBSExtraBrowsers.ui | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UI/forms/OBSExtraBrowsers.ui b/UI/forms/OBSExtraBrowsers.ui index a7d3a27a5..e704fbf76 100644 --- a/UI/forms/OBSExtraBrowsers.ui +++ b/UI/forms/OBSExtraBrowsers.ui @@ -29,10 +29,10 @@ QAbstractItemView::NoSelection - + 23 - + 23 From e324b69c9ff92ffdc2cee2617181e6b9766719f7 Mon Sep 17 00:00:00 2001 From: Warchamp7 Date: Tue, 17 Aug 2021 05:42:05 -0400 Subject: [PATCH 09/12] UI: Clean up Importer form markup Minor alphabetical rearrange by Qt Creator --- UI/forms/OBSImporter.ui | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UI/forms/OBSImporter.ui b/UI/forms/OBSImporter.ui index 7e9706876..691f74079 100644 --- a/UI/forms/OBSImporter.ui +++ b/UI/forms/OBSImporter.ui @@ -29,7 +29,7 @@ - QDialogButtonBox::Close|QDialogButtonBox::Open|QDialogButtonBox::Ok + QDialogButtonBox::Close|QDialogButtonBox::Ok|QDialogButtonBox::Open @@ -40,10 +40,10 @@ QAbstractItemView::NoSelection - + 23 - + 23 From 7deba80aaff54b245094f7510b235532f08d8b16 Mon Sep 17 00:00:00 2001 From: Warchamp7 Date: Tue, 17 Aug 2021 05:42:50 -0400 Subject: [PATCH 10/12] UI: Clean up Missing Files form markup Minor alphabetical rearrange by Qt Creator --- UI/forms/OBSMissingFiles.ui | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/UI/forms/OBSMissingFiles.ui b/UI/forms/OBSMissingFiles.ui index 93523b16e..be9bc4cfd 100644 --- a/UI/forms/OBSMissingFiles.ui +++ b/UI/forms/OBSMissingFiles.ui @@ -20,6 +20,7 @@ + 0 20 @@ -45,10 +46,10 @@ QAbstractItemView::NoSelection - + 23 - + 23 @@ -108,8 +109,8 @@ - - + + From 95cdc0eba2faf0efa3ed0716a6ca515fb8487cd5 Mon Sep 17 00:00:00 2001 From: Warchamp7 Date: Tue, 17 Aug 2021 05:43:36 -0400 Subject: [PATCH 11/12] UI: Clean up Remux form markup Minor alphabetical rearrange by Qt Creator --- UI/forms/OBSRemux.ui | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UI/forms/OBSRemux.ui b/UI/forms/OBSRemux.ui index 0f762b30c..d133b36ca 100644 --- a/UI/forms/OBSRemux.ui +++ b/UI/forms/OBSRemux.ui @@ -40,10 +40,10 @@ QAbstractItemView::NoSelection - + 23 - + 23 From 592570bb2bfcb93199004dd3263ecebfd2e89f6a Mon Sep 17 00:00:00 2001 From: Warchamp7 Date: Tue, 17 Aug 2021 05:44:29 -0400 Subject: [PATCH 12/12] UI: Clean up Update form markup Small whitespace fix --- UI/forms/OBSUpdate.ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UI/forms/OBSUpdate.ui b/UI/forms/OBSUpdate.ui index 86c0aa4b0..d9a003409 100644 --- a/UI/forms/OBSUpdate.ui +++ b/UI/forms/OBSUpdate.ui @@ -34,7 +34,7 @@ p, li { white-space: pre-wrap; } <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; font-size:8pt;"><br /></p></body></html> - true + true