From 69f217003b047a5ae7da866ef52ae837b3877423 Mon Sep 17 00:00:00 2001 From: Dmitry-Me Date: Mon, 30 Jul 2018 15:11:41 +0300 Subject: [PATCH] UI: Check pointer before the first dereference --- UI/window-basic-settings.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UI/window-basic-settings.cpp b/UI/window-basic-settings.cpp index 968af51fc..08e56f46c 100644 --- a/UI/window-basic-settings.cpp +++ b/UI/window-basic-settings.cpp @@ -4185,6 +4185,9 @@ void OBSBasicSettings::AdvReplayBufferChanged() int vbitrate = (int)obs_data_get_int(settings, "bitrate"); const char *rateControl = obs_data_get_string(settings, "rate_control"); + if (!rateControl) + rateControl = ""; + bool lossless = strcmp(rateControl, "lossless") == 0 || ui->advOutRecType->currentIndex() == 1; bool replayBufferEnabled = ui->advReplayBuf->isChecked(); @@ -4210,9 +4213,6 @@ void OBSBasicSettings::AdvReplayBufferChanged() if (memMB < 1) memMB = 1; - if (!rateControl) - rateControl = ""; - bool varRateControl = (astrcmpi(rateControl, "CBR") == 0 || astrcmpi(rateControl, "VBR") == 0 || astrcmpi(rateControl, "ABR") == 0);