From 608219ad6bc53f6289aed404273c48df945844b3 Mon Sep 17 00:00:00 2001 From: gxalpha Date: Mon, 3 Jan 2022 22:01:09 +0100 Subject: [PATCH] UI: Fix "Null 'source' parameter" warning --- UI/window-basic-main-transitions.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/UI/window-basic-main-transitions.cpp b/UI/window-basic-main-transitions.cpp index 5daa09252..793a54e08 100644 --- a/UI/window-basic-main-transitions.cpp +++ b/UI/window-basic-main-transitions.cpp @@ -1118,9 +1118,11 @@ QMenu *OBSBasic::CreateVisibilityTransitionMenu(bool visible) new QMenu(QTStr(visible ? "ShowTransition" : "HideTransition")); QAction *action; - const char *curId = obs_source_get_id( + OBSSource curTransition = visible ? obs_sceneitem_get_show_transition(si) - : obs_sceneitem_get_hide_transition(si)); + : obs_sceneitem_get_hide_transition(si); + const char *curId = curTransition ? obs_source_get_id(curTransition) + : nullptr; int curDuration = (int)(visible ? obs_sceneitem_get_show_transition_duration(si) : obs_sceneitem_get_hide_transition_duration(si));