From 15ca247d534fcdfe9b794702ddc73cbce9d4f27c Mon Sep 17 00:00:00 2001 From: Alexander Surma Date: Tue, 17 Mar 2015 16:17:47 +0000 Subject: [PATCH 1/3] Check for existance of `for` target in MaterialTooltip --- src/tooltip/tooltip.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/tooltip/tooltip.js b/src/tooltip/tooltip.js index 9e13b554..de988461 100644 --- a/src/tooltip/tooltip.js +++ b/src/tooltip/tooltip.js @@ -72,11 +72,16 @@ MaterialTooltip.prototype.init = function() { if (this.element_) { var forElId = this.element_.getAttribute('for'); - var forEl = document.getElementById(forElId); + forEl; + if(forElId) { + forEl = document.getElementById(forElId); + } - forEl.addEventListener('mouseenter', this.handleMouseEnter_.bind(this), - false); - forEl.addEventListener('mouseleave', this.handleMouseLeave_.bind(this)); + if(forEl) { + forEl.addEventListener('mouseenter', this.handleMouseEnter_.bind(this), + false); + forEl.addEventListener('mouseleave', this.handleMouseLeave_.bind(this)); + } } }; From 8ac3d5f838dce19bb3c5fe00be617e1cfef89ff3 Mon Sep 17 00:00:00 2001 From: Alexander Surma Date: Wed, 18 Mar 2015 12:27:35 +0000 Subject: [PATCH 2/3] Be conformant to style guide --- src/tooltip/tooltip.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tooltip/tooltip.js b/src/tooltip/tooltip.js index de988461..1b70c0e2 100644 --- a/src/tooltip/tooltip.js +++ b/src/tooltip/tooltip.js @@ -73,11 +73,11 @@ MaterialTooltip.prototype.init = function() { if (this.element_) { var forElId = this.element_.getAttribute('for'); forEl; - if(forElId) { + if (forElId) { forEl = document.getElementById(forElId); } - if(forEl) { + if (forEl) { forEl.addEventListener('mouseenter', this.handleMouseEnter_.bind(this), false); forEl.addEventListener('mouseleave', this.handleMouseLeave_.bind(this)); From 13b5fac7dbddc28ec5c63325cc42bc3ea90ae833 Mon Sep 17 00:00:00 2001 From: Alexander Surma Date: Wed, 18 Mar 2015 12:59:06 +0000 Subject: [PATCH 3/3] Make empty initializations explicit --- src/tooltip/tooltip.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tooltip/tooltip.js b/src/tooltip/tooltip.js index 1b70c0e2..0b9806f1 100644 --- a/src/tooltip/tooltip.js +++ b/src/tooltip/tooltip.js @@ -72,7 +72,7 @@ MaterialTooltip.prototype.init = function() { if (this.element_) { var forElId = this.element_.getAttribute('for'); - forEl; + forEl = null; if (forElId) { forEl = document.getElementById(forElId); }