From 7cd7a7564baaebdb8f4079e63ec62cd3841dc1d2 Mon Sep 17 00:00:00 2001 From: Jos Collin Date: Thu, 11 May 2017 13:17:20 +0530 Subject: [PATCH] lib/compress: warning: this statement may fall through MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The following warning appears during build. ../lib/compress/huf_compress.c: In function ‘HUF_compress1X_usingCTable’: ../lib/compress/huf_compress.c:444:8: warning: this statement may fall through [-Wimplicit-fallthrough=] if (sizeof((stream)->bitContainer)*8 < HUF_TABLELOG_MAX*4+7) HUF_FLUSHBITS(stream) ^ ../lib/compress/huf_compress.c:465:18: note: in expansion of macro ‘HUF_FLUSHBITS_2’ HUF_FLUSHBITS_2(&bitC); ^~~~~~~~~~~~~~~ ../lib/compress/huf_compress.c:466:9: note: here case 2 : HUF_encodeSymbol(&bitC, ip[n+ 1], CTable); ../lib/compress/zstd_compress.c: In function ‘ZSTD_compressStream_generic’: ../lib/compress/zstd_compress.c:3366:34: warning: this statement may fall through [-Wimplicit-fallthrough=] zcs->streamStage = zcss_flush; /* pass-through to flush stage */ ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ ../lib/compress/zstd_compress.c:3369:9: note: here case zcss_flush: Signed-off-by: Jos Collin --- lib/compress/huf_compress.c | 7 +++++-- lib/compress/zstd_compress.c | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/compress/huf_compress.c b/lib/compress/huf_compress.c index fe11aafb..7248c251 100644 --- a/lib/compress/huf_compress.c +++ b/lib/compress/huf_compress.c @@ -463,12 +463,15 @@ size_t HUF_compress1X_usingCTable(void* dst, size_t dstSize, const void* src, si { case 3 : HUF_encodeSymbol(&bitC, ip[n+ 2], CTable); HUF_FLUSHBITS_2(&bitC); + /* fall-through */ case 2 : HUF_encodeSymbol(&bitC, ip[n+ 1], CTable); HUF_FLUSHBITS_1(&bitC); + /* fall-through */ case 1 : HUF_encodeSymbol(&bitC, ip[n+ 0], CTable); HUF_FLUSHBITS(&bitC); - case 0 : - default: ; + /* fall-through */ + case 0 : /* fall-through */ + default: break; } for (; n>0; n-=4) { /* note : n&3==0 at this stage */ diff --git a/lib/compress/zstd_compress.c b/lib/compress/zstd_compress.c index cb15a5a2..edf4609f 100644 --- a/lib/compress/zstd_compress.c +++ b/lib/compress/zstd_compress.c @@ -3365,7 +3365,7 @@ static size_t ZSTD_compressStream_generic(ZSTD_CStream* zcs, zcs->outBuffFlushedSize = 0; zcs->streamStage = zcss_flush; /* pass-through to flush stage */ } - + /* fall-through */ case zcss_flush: DEBUGLOG(5, "flush stage \n"); { size_t const toFlush = zcs->outBuffContentSize - zcs->outBuffFlushedSize;