From b0c640d9343b8d04b93a137cca5640dedeecd295 Mon Sep 17 00:00:00 2001 From: inikep Date: Thu, 10 Mar 2016 13:18:36 +0100 Subject: [PATCH 1/3] small ratio improvement with MINMATCH=3 --- lib/zstd_opt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/zstd_opt.h b/lib/zstd_opt.h index f89b737a..aa0b7023 100644 --- a/lib/zstd_opt.h +++ b/lib/zstd_opt.h @@ -244,8 +244,8 @@ static U32 ZSTD_insertBtAndGetAllMatches ( if (minMatch == 3) { /* HC3 match finder */ U32 matchIndex3 = ZSTD_insertAndFindFirstIndexHash3 (zc, ip); - - if (matchIndex3>windowLow) { + + if (matchIndex3>windowLow && (current - matchIndex3 < (1<<18))) { const BYTE* match; size_t currentMl=0; if ((!extDict) || matchIndex3 >= dictLimit) { From cc6c2836331f018a0a8f552543590f8bac488599 Mon Sep 17 00:00:00 2001 From: inikep Date: Thu, 10 Mar 2016 15:17:24 +0100 Subject: [PATCH 2/3] removed hashLog3 from ZSTD_parameters --- lib/zstd_compress.c | 202 ++++++++++++++++++++++---------------------- lib/zstd_internal.h | 1 + lib/zstd_opt.h | 5 +- lib/zstd_static.h | 3 - 4 files changed, 103 insertions(+), 108 deletions(-) diff --git a/lib/zstd_compress.c b/lib/zstd_compress.c index 09303195..fc88eb16 100644 --- a/lib/zstd_compress.c +++ b/lib/zstd_compress.c @@ -146,14 +146,12 @@ void ZSTD_validateParams(ZSTD_parameters* params) const U32 btPlus = (params->strategy == ZSTD_btlazy2) || (params->strategy == ZSTD_btopt); const U32 searchLengthMax = (params->strategy == ZSTD_fast) ? ZSTD_SEARCHLENGTH_MAX : ZSTD_SEARCHLENGTH_MAX-1; const U32 searchLengthMin = (params->strategy == ZSTD_btopt) ? ZSTD_SEARCHLENGTH_MIN : ZSTD_SEARCHLENGTH_MIN+1; - const U32 hashLog3Min = (params->strategy == ZSTD_btopt) ? ZSTD_HASHLOG3_MIN : 0; /* validate params */ if (MEM_32bits()) if (params->windowLog > 25) params->windowLog = 25; /* 32 bits mode cannot flush > 24 bits */ CLAMP(params->windowLog, ZSTD_WINDOWLOG_MIN, ZSTD_WINDOWLOG_MAX); CLAMP(params->contentLog, ZSTD_CONTENTLOG_MIN, ZSTD_CONTENTLOG_MAX); CLAMP(params->hashLog, ZSTD_HASHLOG_MIN, ZSTD_HASHLOG_MAX); - CLAMP(params->hashLog3, hashLog3Min, ZSTD_HASHLOG3_MAX); CLAMP(params->searchLog, ZSTD_SEARCHLOG_MIN, ZSTD_SEARCHLOG_MAX); CLAMP(params->searchLength, searchLengthMin, searchLengthMax); CLAMP(params->targetLength, ZSTD_TARGETLENGTH_MIN, ZSTD_TARGETLENGTH_MAX); @@ -176,7 +174,7 @@ size_t ZSTD_sizeofCCtx(ZSTD_parameters params) /* hidden interface, for parama const U32 divider = (params.searchLength==3) ? 3 : 4; const size_t maxNbSeq = blockSize / divider; const size_t tokenSpace = blockSize + 8*maxNbSeq; - const size_t tableSpace = ((1 << contentLog) + (1 << params.hashLog) + (1 << params.hashLog3)) * sizeof(U32); + const size_t tableSpace = ((1 << contentLog) + (1 << params.hashLog) + (1 << HASHLOG3)) * sizeof(U32); const size_t optSpace = ((1<workSpace, 0, tableSpace ); /* reset only tables */ zc->hashTable3 = (U32*)(zc->workSpace); - zc->hashTable = zc->hashTable3 + ((size_t)1 << params.hashLog3); + zc->hashTable = zc->hashTable3 + ((size_t)1 << HASHLOG3); zc->contentTable = zc->hashTable + ((size_t)1 << params.hashLog); zc->seqStore.buffer = zc->contentTable + ((size_t)1 << contentLog); zc->hufTable = (HUF_CElt*)zc->seqStore.buffer; @@ -253,7 +251,7 @@ static size_t ZSTD_resetCCtx_advanced (ZSTD_CCtx* zc, size_t ZSTD_copyCCtx(ZSTD_CCtx* dstCCtx, const ZSTD_CCtx* srcCCtx) { const U32 contentLog = (srcCCtx->params.strategy == ZSTD_fast) ? 1 : srcCCtx->params.contentLog; - const size_t tableSpace = ((1 << contentLog) + (1 << srcCCtx->params.hashLog) + (1 << srcCCtx->params.hashLog3)) * sizeof(U32); + const size_t tableSpace = ((1 << contentLog) + (1 << srcCCtx->params.hashLog) + (1 << HASHLOG3)) * sizeof(U32); if (srcCCtx->stage!=0) return ERROR(stage_wrong); @@ -2301,108 +2299,108 @@ unsigned ZSTD_maxCLevel(void) { return ZSTD_MAX_CLEVEL; } static const ZSTD_parameters ZSTD_defaultParameters[4][ZSTD_MAX_CLEVEL+1] = { { /* "default" */ - /* l, W, C, H, H3, S, L, SL, strat */ - { 0, 0, 0, 0, 0, 0, 0, 0, ZSTD_fast }, /* level 0 - never used */ - { 0, 19, 13, 14, 0, 1, 7, 4, ZSTD_fast }, /* level 1 */ - { 0, 19, 15, 16, 0, 1, 6, 4, ZSTD_fast }, /* level 2 */ - { 0, 20, 18, 20, 0, 1, 6, 4, ZSTD_fast }, /* level 3 */ - { 0, 20, 13, 17, 0, 2, 5, 4, ZSTD_greedy }, /* level 4.*/ - { 0, 20, 15, 18, 0, 3, 5, 4, ZSTD_greedy }, /* level 5 */ - { 0, 21, 16, 19, 0, 2, 5, 4, ZSTD_lazy }, /* level 6 */ - { 0, 21, 17, 20, 0, 3, 5, 4, ZSTD_lazy }, /* level 7 */ - { 0, 21, 18, 20, 0, 3, 5, 4, ZSTD_lazy2 }, /* level 8.*/ - { 0, 21, 20, 20, 0, 3, 5, 4, ZSTD_lazy2 }, /* level 9 */ - { 0, 21, 19, 21, 0, 4, 5, 4, ZSTD_lazy2 }, /* level 10 */ - { 0, 22, 20, 22, 0, 4, 5, 4, ZSTD_lazy2 }, /* level 11 */ - { 0, 22, 20, 22, 0, 5, 5, 4, ZSTD_lazy2 }, /* level 12 */ - { 0, 22, 21, 22, 0, 5, 5, 4, ZSTD_lazy2 }, /* level 13 */ - { 0, 22, 21, 22, 0, 6, 5, 4, ZSTD_lazy2 }, /* level 14 */ - { 0, 22, 21, 21, 0, 5, 5, 4, ZSTD_btlazy2 }, /* level 15 */ - { 0, 23, 22, 22, 0, 5, 5, 4, ZSTD_btlazy2 }, /* level 16 */ - { 0, 23, 22, 22, 0, 6, 5, 22, ZSTD_btopt }, /* level 17 */ - { 0, 22, 22, 22, 0, 5, 3, 44, ZSTD_btopt }, /* level 18 */ - { 0, 23, 24, 22, 0, 7, 3, 44, ZSTD_btopt }, /* level 19 */ - { 0, 25, 26, 22, 0, 7, 3, 71, ZSTD_btopt }, /* level 20 */ - { 0, 26, 26, 24, 0, 7, 3,256, ZSTD_btopt }, /* level 21 */ - { 0, 27, 28, 26, 0, 9, 3,256, ZSTD_btopt }, /* level 22 */ + /* l, W, C, H, S, L, SL, strat */ + { 0, 0, 0, 0, 0, 0, 0, ZSTD_fast }, /* level 0 - never used */ + { 0, 19, 13, 14, 1, 7, 4, ZSTD_fast }, /* level 1 */ + { 0, 19, 15, 16, 1, 6, 4, ZSTD_fast }, /* level 2 */ + { 0, 20, 18, 20, 1, 6, 4, ZSTD_fast }, /* level 3 */ + { 0, 20, 13, 17, 2, 5, 4, ZSTD_greedy }, /* level 4.*/ + { 0, 20, 15, 18, 3, 5, 4, ZSTD_greedy }, /* level 5 */ + { 0, 21, 16, 19, 2, 5, 4, ZSTD_lazy }, /* level 6 */ + { 0, 21, 17, 20, 3, 5, 4, ZSTD_lazy }, /* level 7 */ + { 0, 21, 18, 20, 3, 5, 4, ZSTD_lazy2 }, /* level 8.*/ + { 0, 21, 20, 20, 3, 5, 4, ZSTD_lazy2 }, /* level 9 */ + { 0, 21, 19, 21, 4, 5, 4, ZSTD_lazy2 }, /* level 10 */ + { 0, 22, 20, 22, 4, 5, 4, ZSTD_lazy2 }, /* level 11 */ + { 0, 22, 20, 22, 5, 5, 4, ZSTD_lazy2 }, /* level 12 */ + { 0, 22, 21, 22, 5, 5, 4, ZSTD_lazy2 }, /* level 13 */ + { 0, 22, 21, 22, 6, 5, 4, ZSTD_lazy2 }, /* level 14 */ + { 0, 22, 21, 21, 5, 5, 4, ZSTD_btlazy2 }, /* level 15 */ + { 0, 23, 22, 22, 5, 5, 4, ZSTD_btlazy2 }, /* level 16 */ + { 0, 23, 22, 22, 6, 5, 22, ZSTD_btopt }, /* level 17 */ + { 0, 22, 22, 22, 5, 3, 44, ZSTD_btopt }, /* level 18 */ + { 0, 23, 24, 22, 7, 3, 44, ZSTD_btopt }, /* level 19 */ + { 0, 25, 26, 22, 7, 3, 71, ZSTD_btopt }, /* level 20 */ + { 0, 26, 26, 24, 7, 3,256, ZSTD_btopt }, /* level 21 */ + { 0, 27, 28, 26, 9, 3,256, ZSTD_btopt }, /* level 22 */ }, { /* for srcSize <= 256 KB */ - /* l, W, C, H, H3, S, L, T, strat */ - { 0, 0, 0, 0, 0, 0, 0, 0, ZSTD_fast }, /* level 0 */ - { 0, 18, 14, 15, 0, 1, 6, 4, ZSTD_fast }, /* level 1 */ - { 0, 18, 14, 16, 0, 1, 5, 4, ZSTD_fast }, /* level 2 */ - { 0, 18, 14, 17, 0, 1, 5, 4, ZSTD_fast }, /* level 3.*/ - { 0, 18, 14, 15, 0, 4, 4, 4, ZSTD_greedy }, /* level 4 */ - { 0, 18, 16, 17, 0, 4, 4, 4, ZSTD_greedy }, /* level 5 */ - { 0, 18, 17, 17, 0, 3, 4, 4, ZSTD_lazy }, /* level 6 */ - { 0, 18, 17, 17, 0, 4, 4, 4, ZSTD_lazy }, /* level 7 */ - { 0, 18, 17, 17, 0, 4, 4, 4, ZSTD_lazy2 }, /* level 8 */ - { 0, 18, 17, 17, 0, 5, 4, 4, ZSTD_lazy2 }, /* level 9 */ - { 0, 18, 17, 17, 0, 6, 4, 4, ZSTD_lazy2 }, /* level 10 */ - { 0, 18, 17, 17, 0, 7, 4, 4, ZSTD_lazy2 }, /* level 11 */ - { 0, 18, 18, 17, 0, 4, 4, 4, ZSTD_btlazy2 }, /* level 12 */ - { 0, 18, 19, 17, 0, 7, 4, 4, ZSTD_btlazy2 }, /* level 13.*/ - { 0, 18, 17, 19, 0, 8, 4, 24, ZSTD_btopt }, /* level 14.*/ - { 0, 18, 19, 19, 0, 8, 4, 48, ZSTD_btopt }, /* level 15.*/ - { 0, 18, 19, 18, 0, 9, 4,128, ZSTD_btopt }, /* level 16.*/ - { 0, 18, 19, 18, 0, 9, 4,192, ZSTD_btopt }, /* level 17.*/ - { 0, 18, 19, 18, 0, 9, 4,256, ZSTD_btopt }, /* level 18.*/ - { 0, 18, 19, 18, 0, 10, 4,256, ZSTD_btopt }, /* level 19.*/ - { 0, 18, 19, 18, 0, 11, 4,256, ZSTD_btopt }, /* level 20.*/ - { 0, 18, 19, 18, 0, 12, 4,256, ZSTD_btopt }, /* level 21.*/ - { 0, 18, 19, 18, 0, 12, 4,256, ZSTD_btopt }, /* level 21-2*/ + /* l, W, C, H, S, L, T, strat */ + { 0, 0, 0, 0, 0, 0, 0, ZSTD_fast }, /* level 0 */ + { 0, 18, 14, 15, 1, 6, 4, ZSTD_fast }, /* level 1 */ + { 0, 18, 14, 16, 1, 5, 4, ZSTD_fast }, /* level 2 */ + { 0, 18, 14, 17, 1, 5, 4, ZSTD_fast }, /* level 3.*/ + { 0, 18, 14, 15, 4, 4, 4, ZSTD_greedy }, /* level 4 */ + { 0, 18, 16, 17, 4, 4, 4, ZSTD_greedy }, /* level 5 */ + { 0, 18, 17, 17, 3, 4, 4, ZSTD_lazy }, /* level 6 */ + { 0, 18, 17, 17, 4, 4, 4, ZSTD_lazy }, /* level 7 */ + { 0, 18, 17, 17, 4, 4, 4, ZSTD_lazy2 }, /* level 8 */ + { 0, 18, 17, 17, 5, 4, 4, ZSTD_lazy2 }, /* level 9 */ + { 0, 18, 17, 17, 6, 4, 4, ZSTD_lazy2 }, /* level 10 */ + { 0, 18, 17, 17, 7, 4, 4, ZSTD_lazy2 }, /* level 11 */ + { 0, 18, 18, 17, 4, 4, 4, ZSTD_btlazy2 }, /* level 12 */ + { 0, 18, 19, 17, 7, 4, 4, ZSTD_btlazy2 }, /* level 13.*/ + { 0, 18, 17, 19, 8, 4, 24, ZSTD_btopt }, /* level 14.*/ + { 0, 18, 19, 19, 8, 4, 48, ZSTD_btopt }, /* level 15.*/ + { 0, 18, 19, 18, 9, 4,128, ZSTD_btopt }, /* level 16.*/ + { 0, 18, 19, 18, 9, 4,192, ZSTD_btopt }, /* level 17.*/ + { 0, 18, 19, 18, 9, 4,256, ZSTD_btopt }, /* level 18.*/ + { 0, 18, 19, 18, 10, 4,256, ZSTD_btopt }, /* level 19.*/ + { 0, 18, 19, 18, 11, 4,256, ZSTD_btopt }, /* level 20.*/ + { 0, 18, 19, 18, 12, 4,256, ZSTD_btopt }, /* level 21.*/ + { 0, 18, 19, 18, 12, 4,256, ZSTD_btopt }, /* level 22*/ }, { /* for srcSize <= 128 KB */ - /* l, W, C, H, H3, S, L, T, strat */ - { 0, 0, 0, 0, 0, 0, 0, 0, ZSTD_fast }, /* level 0 - never used */ - { 0, 17, 12, 13, 0, 1, 6, 4, ZSTD_fast }, /* level 1 */ - { 0, 17, 13, 16, 0, 1, 5, 4, ZSTD_fast }, /* level 2 */ - { 0, 17, 13, 14, 0, 2, 5, 4, ZSTD_greedy }, /* level 3 */ - { 0, 17, 13, 15, 0, 3, 4, 4, ZSTD_greedy }, /* level 4 */ - { 0, 17, 15, 17, 0, 4, 4, 4, ZSTD_greedy }, /* level 5 */ - { 0, 17, 16, 17, 0, 3, 4, 4, ZSTD_lazy }, /* level 6 */ - { 0, 17, 15, 17, 0, 4, 4, 4, ZSTD_lazy2 }, /* level 7 */ - { 0, 17, 17, 17, 0, 4, 4, 4, ZSTD_lazy2 }, /* level 8 */ - { 0, 17, 17, 17, 0, 5, 4, 4, ZSTD_lazy2 }, /* level 9 */ - { 0, 17, 17, 17, 0, 6, 4, 4, ZSTD_lazy2 }, /* level 10 */ - { 0, 17, 17, 17, 0, 7, 4, 4, ZSTD_lazy2 }, /* level 11 */ - { 0, 17, 17, 17, 0, 8, 4, 4, ZSTD_lazy2 }, /* level 12 */ - { 0, 17, 18, 17, 0, 6, 4, 4, ZSTD_btlazy2 }, /* level 13.*/ - { 0, 17, 17, 17, 16, 7, 3, 8, ZSTD_btopt }, /* level 14.*/ - { 0, 17, 17, 17, 16, 7, 3, 16, ZSTD_btopt }, /* level 15.*/ - { 0, 17, 18, 17, 16, 7, 3, 32, ZSTD_btopt }, /* level 16.*/ - { 0, 17, 18, 17, 16, 7, 3, 64, ZSTD_btopt }, /* level 17.*/ - { 0, 17, 18, 17, 16, 7, 3,256, ZSTD_btopt }, /* level 18.*/ - { 0, 17, 18, 17, 16, 8, 3,256, ZSTD_btopt }, /* level 19.*/ - { 0, 17, 18, 17, 16, 9, 3,256, ZSTD_btopt }, /* level 20.*/ - { 0, 17, 18, 17, 16, 10, 3,256, ZSTD_btopt }, /* level 21.*/ - { 0, 17, 18, 17, 16, 11, 3,256, ZSTD_btopt }, /* level 22.*/ + /* l, W, C, H, S, L, T, strat */ + { 0, 0, 0, 0, 0, 0, 0, ZSTD_fast }, /* level 0 - never used */ + { 0, 17, 12, 13, 1, 6, 4, ZSTD_fast }, /* level 1 */ + { 0, 17, 13, 16, 1, 5, 4, ZSTD_fast }, /* level 2 */ + { 0, 17, 13, 14, 2, 5, 4, ZSTD_greedy }, /* level 3 */ + { 0, 17, 13, 15, 3, 4, 4, ZSTD_greedy }, /* level 4 */ + { 0, 17, 15, 17, 4, 4, 4, ZSTD_greedy }, /* level 5 */ + { 0, 17, 16, 17, 3, 4, 4, ZSTD_lazy }, /* level 6 */ + { 0, 17, 15, 17, 4, 4, 4, ZSTD_lazy2 }, /* level 7 */ + { 0, 17, 17, 17, 4, 4, 4, ZSTD_lazy2 }, /* level 8 */ + { 0, 17, 17, 17, 5, 4, 4, ZSTD_lazy2 }, /* level 9 */ + { 0, 17, 17, 17, 6, 4, 4, ZSTD_lazy2 }, /* level 10 */ + { 0, 17, 17, 17, 7, 4, 4, ZSTD_lazy2 }, /* level 11 */ + { 0, 17, 17, 17, 8, 4, 4, ZSTD_lazy2 }, /* level 12 */ + { 0, 17, 18, 17, 6, 4, 4, ZSTD_btlazy2 }, /* level 13.*/ + { 0, 17, 17, 17, 7, 3, 8, ZSTD_btopt }, /* level 14.*/ + { 0, 17, 17, 17, 7, 3, 16, ZSTD_btopt }, /* level 15.*/ + { 0, 17, 18, 17, 7, 3, 32, ZSTD_btopt }, /* level 16.*/ + { 0, 17, 18, 17, 7, 3, 64, ZSTD_btopt }, /* level 17.*/ + { 0, 17, 18, 17, 7, 3,256, ZSTD_btopt }, /* level 18.*/ + { 0, 17, 18, 17, 8, 3,256, ZSTD_btopt }, /* level 19.*/ + { 0, 17, 18, 17, 9, 3,256, ZSTD_btopt }, /* level 20.*/ + { 0, 17, 18, 17, 10, 3,256, ZSTD_btopt }, /* level 21.*/ + { 0, 17, 18, 17, 11, 3,256, ZSTD_btopt }, /* level 22.*/ }, { /* for srcSize <= 16 KB */ - /* l, W, C, H, H3, S, L, T, strat */ - { 0, 0, 0, 0, 0, 0, 0, 0, ZSTD_fast }, /* level 0 -- never used */ - { 0, 14, 14, 14, 0, 1, 4, 4, ZSTD_fast }, /* level 1 */ - { 0, 14, 14, 15, 0, 1, 4, 4, ZSTD_fast }, /* level 2 */ - { 0, 14, 14, 14, 0, 4, 4, 4, ZSTD_greedy }, /* level 3.*/ - { 0, 14, 14, 14, 0, 3, 4, 4, ZSTD_lazy }, /* level 4.*/ - { 0, 14, 14, 14, 0, 4, 4, 4, ZSTD_lazy2 }, /* level 5 */ - { 0, 14, 14, 14, 0, 5, 4, 4, ZSTD_lazy2 }, /* level 6 */ - { 0, 14, 14, 14, 0, 6, 4, 4, ZSTD_lazy2 }, /* level 7.*/ - { 0, 14, 14, 14, 0, 7, 4, 4, ZSTD_lazy2 }, /* level 8.*/ - { 0, 14, 15, 14, 0, 6, 4, 4, ZSTD_btlazy2 }, /* level 9.*/ - { 0, 14, 15, 14, 16, 3, 3, 6, ZSTD_btopt }, /* level 10.*/ - { 0, 14, 15, 14, 16, 6, 3, 8, ZSTD_btopt }, /* level 11.*/ - { 0, 14, 15, 14, 16, 6, 3, 16, ZSTD_btopt }, /* level 12.*/ - { 0, 14, 15, 14, 16, 6, 3, 24, ZSTD_btopt }, /* level 13.*/ - { 0, 14, 15, 15, 16, 6, 3, 48, ZSTD_btopt }, /* level 14.*/ - { 0, 14, 15, 15, 16, 6, 3, 64, ZSTD_btopt }, /* level 15.*/ - { 0, 14, 15, 15, 16, 6, 3, 96, ZSTD_btopt }, /* level 16.*/ - { 0, 14, 15, 15, 16, 6, 3,128, ZSTD_btopt }, /* level 17.*/ - { 0, 14, 15, 15, 16, 6, 3,256, ZSTD_btopt }, /* level 18.*/ - { 0, 14, 15, 15, 16, 7, 3,256, ZSTD_btopt }, /* level 19.*/ - { 0, 14, 15, 15, 16, 8, 3,256, ZSTD_btopt }, /* level 20.*/ - { 0, 14, 15, 15, 16, 9, 3,256, ZSTD_btopt }, /* level 21.*/ - { 0, 14, 15, 15, 16, 10, 3,256, ZSTD_btopt }, /* level 22.*/ + /* l, W, C, H, S, L, T, strat */ + { 0, 0, 0, 0, 0, 0, 0, ZSTD_fast }, /* level 0 -- never used */ + { 0, 14, 14, 14, 1, 4, 4, ZSTD_fast }, /* level 1 */ + { 0, 14, 14, 15, 1, 4, 4, ZSTD_fast }, /* level 2 */ + { 0, 14, 14, 14, 4, 4, 4, ZSTD_greedy }, /* level 3.*/ + { 0, 14, 14, 14, 3, 4, 4, ZSTD_lazy }, /* level 4.*/ + { 0, 14, 14, 14, 4, 4, 4, ZSTD_lazy2 }, /* level 5 */ + { 0, 14, 14, 14, 5, 4, 4, ZSTD_lazy2 }, /* level 6 */ + { 0, 14, 14, 14, 6, 4, 4, ZSTD_lazy2 }, /* level 7.*/ + { 0, 14, 14, 14, 7, 4, 4, ZSTD_lazy2 }, /* level 8.*/ + { 0, 14, 15, 14, 6, 4, 4, ZSTD_btlazy2 }, /* level 9.*/ + { 0, 14, 15, 14, 3, 3, 6, ZSTD_btopt }, /* level 10.*/ + { 0, 14, 15, 14, 6, 3, 8, ZSTD_btopt }, /* level 11.*/ + { 0, 14, 15, 14, 6, 3, 16, ZSTD_btopt }, /* level 12.*/ + { 0, 14, 15, 14, 6, 3, 24, ZSTD_btopt }, /* level 13.*/ + { 0, 14, 15, 15, 6, 3, 48, ZSTD_btopt }, /* level 14.*/ + { 0, 14, 15, 15, 6, 3, 64, ZSTD_btopt }, /* level 15.*/ + { 0, 14, 15, 15, 6, 3, 96, ZSTD_btopt }, /* level 16.*/ + { 0, 14, 15, 15, 6, 3,128, ZSTD_btopt }, /* level 17.*/ + { 0, 14, 15, 15, 6, 3,256, ZSTD_btopt }, /* level 18.*/ + { 0, 14, 15, 15, 7, 3,256, ZSTD_btopt }, /* level 19.*/ + { 0, 14, 15, 15, 8, 3,256, ZSTD_btopt }, /* level 20.*/ + { 0, 14, 15, 15, 9, 3,256, ZSTD_btopt }, /* level 21.*/ + { 0, 14, 15, 15, 10, 3,256, ZSTD_btopt }, /* level 22.*/ }, }; diff --git a/lib/zstd_internal.h b/lib/zstd_internal.h index ec7e72f2..409e5e57 100644 --- a/lib/zstd_internal.h +++ b/lib/zstd_internal.h @@ -114,6 +114,7 @@ static const size_t ZSTD_frameHeaderSize_min = 5; #define FSE_ENCODING_DYNAMIC 3 #define HufLog 12 +#define HASHLOG3 17 #define MIN_SEQUENCES_SIZE 1 /* nbSeq==0 */ #define MIN_CBLOCK_SIZE (1 /*litCSize*/ + 1 /* RLE or RAW */ + MIN_SEQUENCES_SIZE /* nbSeq==0 */) /* for a non-null block */ diff --git a/lib/zstd_opt.h b/lib/zstd_opt.h index aa0b7023..b8c9d67a 100644 --- a/lib/zstd_opt.h +++ b/lib/zstd_opt.h @@ -196,18 +196,17 @@ MEM_STATIC void ZSTD_updatePrice(seqStore_t* seqStorePtr, U32 litLength, const B static U32 ZSTD_insertAndFindFirstIndexHash3 (ZSTD_CCtx* zc, const BYTE* ip) { U32* const hashTable3 = zc->hashTable3; - const U32 hashLog3 = zc->params.hashLog3; const BYTE* const base = zc->base; const U32 target = (U32)(ip - base); U32 idx = zc->nextToUpdate3; while(idx < target) { - hashTable3[ZSTD_hash3Ptr(base+idx, hashLog3)] = idx; + hashTable3[ZSTD_hash3Ptr(base+idx, HASHLOG3)] = idx; idx++; } zc->nextToUpdate3 = target; - return hashTable3[ZSTD_hash3Ptr(ip, hashLog3)]; + return hashTable3[ZSTD_hash3Ptr(ip, HASHLOG3)]; } diff --git a/lib/zstd_static.h b/lib/zstd_static.h index 40522598..4f23fca9 100644 --- a/lib/zstd_static.h +++ b/lib/zstd_static.h @@ -63,8 +63,6 @@ extern "C" { #define ZSTD_CONTENTLOG_MIN 4 #define ZSTD_HASHLOG_MAX 28 #define ZSTD_HASHLOG_MIN 12 -#define ZSTD_HASHLOG3_MAX 16 -#define ZSTD_HASHLOG3_MIN 16 #define ZSTD_SEARCHLOG_MAX (ZSTD_CONTENTLOG_MAX-1) #define ZSTD_SEARCHLOG_MIN 1 #define ZSTD_SEARCHLENGTH_MAX 7 @@ -81,7 +79,6 @@ typedef struct U32 windowLog; /* largest match distance : larger == more compression, more memory needed during decompression */ U32 contentLog; /* full search segment : larger == more compression, slower, more memory (useless for fast) */ U32 hashLog; /* dispatch table : larger == faster, more memory */ - U32 hashLog3; /* dispatch table : larger == faster, more memory */ U32 searchLog; /* nb of searches : larger == more compression, slower */ U32 searchLength; /* match length searched : larger == faster decompression, sometimes less compression */ U32 targetLength; /* acceptable match size for optimal parser (only) : larger == more compression, slower */ From aff4ba17148c304708749b4dc0ab848b39374529 Mon Sep 17 00:00:00 2001 From: inikep Date: Thu, 10 Mar 2016 15:45:21 +0100 Subject: [PATCH 3/3] hashLog3 removed from paramgrill --- programs/paramgrill.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/paramgrill.c b/programs/paramgrill.c index 4a76da8a..fb82d926 100644 --- a/programs/paramgrill.c +++ b/programs/paramgrill.c @@ -127,7 +127,7 @@ static U32 g_rand = 1; static U32 g_singleRun = 0; static U32 g_target = 0; static U32 g_noSeed = 0; -static ZSTD_parameters g_params = { 0, 0, 0, 0, 0, 0, 0, 0, ZSTD_greedy }; +static ZSTD_parameters g_params = { 0, 0, 0, 0, 0, 0, 0, ZSTD_greedy }; void BMK_SetNbIterations(int nbLoops) {