From ee9560b2775c78d26c7be0065575412de3151f05 Mon Sep 17 00:00:00 2001 From: expertmm <7557867+expertmm@users.noreply.github.com> Date: Thu, 15 Feb 2018 18:51:04 -0500 Subject: [PATCH] start conforming params to official minetestmapper --- README.md | 11 +++++++++++ minetestmapper-numpy.py | 4 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index b467a35..1461bcb 100644 --- a/README.md +++ b/README.md @@ -23,9 +23,20 @@ Use python to make minetest maps from worlds. * Python Imaging Library: http://www.pythonware.com/products/pil/ * The colors.txt should be generated by for the most complete colors list (unless you use the more complicated [minetestmapper method]([https://github.com/minetest/minetestmapper])) and prettiest map until that code is moved from EnlivenMinetest to the minetestmapper-python project. +## Known Issues: +* has exception for unknown reason which may be related to why it doesn't draw higher than y=0 see `print("")` +* conform minetestmapper-numpy.py to official minetestmapper: + * make input path to go after an `-i` param instead of being positional + * make output path to go after an `-o` param instead of being positional + * add `--geometry` param + * add `--colors` param (see `load_colors()` which should be `load_colors(fname=x)` where x is a path specified by the user) +* conform minetestmapper.py to official minetestmapper: + * add `--min-y` and `--max-y` params (see `for y in reversed(range(16)):`?) + ## Changes (2018-02-15) * expertmm: clarified license notices in python files +* expertmm: (minetestmapper-numpy.py) changed minheight and maxheight to --min-y and --max-y to conform to official minetestmapper (2018-02-14) * expertmm: (minetestmapper-numpy.py) fixed exception while showing exception (see "Could not finish writing r error since r was not initialized")--the original exception occurs for unknown reason (2017-04-12) diff --git a/minetestmapper-numpy.py b/minetestmapper-numpy.py index af4a7a8..7925e05 100644 --- a/minetestmapper-numpy.py +++ b/minetestmapper-numpy.py @@ -196,8 +196,8 @@ def parse_args(): parser.add_argument('--drawunderground',dest='drawunderground',action='store_const', const = 1, default = 0, help = 'draw underground areas overlaid on the map') parser.add_argument('--drawunderground-standalone',dest='drawunderground',action='store_const', const = 2, help = 'draw underground areas as a standalone map') parser.add_argument('--region', nargs=4, type = int, metavar = ('XMIN','XMAX','ZMIN','ZMAX'), default = (-2000,2000,-2000,2000),help = 'set the bounding x,z coordinates for the map (units are nodes, default = -2000 2000 -2000 2000)') - parser.add_argument('--maxheight', type = int, metavar = ('YMAX'), default = 500, help = 'don\'t draw above height YMAX (default = 500)') - parser.add_argument('--minheight', type = int, metavar = ('YMIN'), default = -500, help = 'don\'t draw below height YMIN (defualt = -500)') + parser.add_argument('--max-y', type = int, metavar = ('YMAX'), default = 500, help = 'don\'t draw above height YMAX (default = 500)') + parser.add_argument('--min-y', type = int, metavar = ('YMIN'), default = -500, help = 'don\'t draw below height YMIN (defualt = -500)') parser.add_argument('--pixelspernode', type = int, metavar = ('PPN'), default = 1, help = 'number of pixels per node (default = 1)') parser.add_argument('--facing', type = str, choices = ('up','down','north','south','east','west'),default='down',help = 'direction to face when drawing (north, south, east or west will draw a cross-section)') parser.add_argument('--fog', type = float, metavar = ('FOGSTRENGTH'), default = 0.0, help = 'use fog strength of FOGSTRENGTH (0.0 by default, max of 1.0)')