From 42e9e7d02f912630d695416beb56a14543f25402 Mon Sep 17 00:00:00 2001
From: sdua <sahildua2305@gmail.com>
Date: Sat, 9 Jul 2016 10:49:57 +0000
Subject: [PATCH] Frequency: Refactor tests to remove duplication

---
 t/Frequency.t | 42 ++++++++++++------------------------------
 1 file changed, 12 insertions(+), 30 deletions(-)

diff --git a/t/Frequency.t b/t/Frequency.t
index e1003a08f..0ff592371 100644
--- a/t/Frequency.t
+++ b/t/Frequency.t
@@ -11,6 +11,12 @@ zci answer_type => 'frequency';
 
 my $all_chars_subtitle = "Frequency of all characters";
 
+my @test_response = ('e:1/4 s:1/4 t:2/4', "test", "$all_chars_subtitle", {
+    'e' => 1,
+    's' => 1,
+    't' => 2
+}, ['e', 's', 't']);
+
 sub build_structured_test {
     my ($plaintext, $title, $subtitle, $record_data, $record_keys) = @_;
 
@@ -40,41 +46,17 @@ ddg_goodie_test(
                 DDG::Goodie::Frequency
         )],
 
-    "frequency of all in test" => build_test('e:1/4 s:1/4 t:2/4', "test", "$all_chars_subtitle", {
-        'e' => 1,
-        's' => 1,
-        't' => 2
-    }, ['e', 's', 't']),
+    "frequency of all in test" => build_test(@test_response),
 
-    'frequency of all letters in test' => build_test('e:1/4 s:1/4 t:2/4', "test", "$all_chars_subtitle", {
-        'e' => 1,
-        's' => 1,
-        't' => 2
-    }, ['e', 's', 't']),
+    'frequency of all letters in test' => build_test(@test_response),
 
-    'frequency of letters in test' => build_test('e:1/4 s:1/4 t:2/4', "test", "$all_chars_subtitle", {
-        'e' => 1,
-        's' => 1,
-        't' => 2
-    }, ['e', 's', 't']),
+    'frequency of letters in test' => build_test(@test_response),
 
-    'frequency of all characters in test' => build_test('e:1/4 s:1/4 t:2/4', "test", "$all_chars_subtitle", {
-        'e' => 1,
-        's' => 1,
-        't' => 2
-    }, ['e', 's', 't']),
+    'frequency of all characters in test' => build_test(@test_response),
 
-    'frequency of all alphabets in test' => build_test('e:1/4 s:1/4 t:2/4', "test", "$all_chars_subtitle", {
-        'e' => 1,
-        's' => 1,
-        't' => 2
-    }, ['e', 's', 't']),
+    'frequency of all alphabets in test' => build_test(@test_response),
 
-    'frequency of all chars in test' => build_test('e:1/4 s:1/4 t:2/4', "test", "$all_chars_subtitle", {
-        'e' => 1,
-        's' => 1,
-        't' => 2
-    }, ['e', 's', 't']),
+    'frequency of all chars in test' => build_test(@test_response),
 
     'frequency of all in testing 1234 ABC!' => build_test('a:1/10 b:1/10 c:1/10 e:1/10 g:1/10 i:1/10 n:1/10 s:1/10 t:2/10', "testing 1234 ABC!", "$all_chars_subtitle", {
         'a' => 1,