From 31a7758fc77d53410a8106e119bfa555cac771f5 Mon Sep 17 00:00:00 2001 From: uniphil Date: Fri, 24 Apr 2015 12:46:30 +0000 Subject: [PATCH] Update goodie from review feedback `use strict;` added -- I couln't find info on whether it had to be one line 1 or not, so I put it where @MrChrisW wrote a comment asking for it. changed description and user-facing text to be exactly what the tutorial told me to write. --- lib/DDG/Goodie/IsAwesome/uniphil.pm | 5 +++-- t/IsAwesome/uniphil.t | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/DDG/Goodie/IsAwesome/uniphil.pm b/lib/DDG/Goodie/IsAwesome/uniphil.pm index 768928edc..630ad2dfd 100644 --- a/lib/DDG/Goodie/IsAwesome/uniphil.pm +++ b/lib/DDG/Goodie/IsAwesome/uniphil.pm @@ -2,12 +2,13 @@ package DDG::Goodie::IsAwesome::uniphil; # ABSTRACT: uniphil's first Goodie use DDG::Goodie; +use strict; zci answer_type => "is_awesome_uniphil"; zci is_cached => 1; name "IsAwesome uniphil"; -description "My first Goodie, like so many before, in hopes of having a search engine tell me I'm awesome"; +description "My first Goodie, it lets the world know uniphil is awesome"; primary_example_queries "duckduckhack uniphil"; category "special"; topics "special_interest", "geek"; @@ -19,7 +20,7 @@ triggers start => "duckduckhack uniphil"; handle remainder => sub { return if $_; - return "uniphil is awesome I guess. They successfully completed the DuckDuckHack Goodie tutorial anyway." + return "uniphil is awesome and has successfully completed the DuckDuckHack Goodie tutorial!" }; 1; diff --git a/t/IsAwesome/uniphil.t b/t/IsAwesome/uniphil.t index b3da44e04..d0b15f06b 100644 --- a/t/IsAwesome/uniphil.t +++ b/t/IsAwesome/uniphil.t @@ -12,7 +12,7 @@ ddg_goodie_test( [qw( DDG::Goodie::IsAwesome::uniphil )], - 'duckduckhack uniphil' => test_zci('uniphil is awesome I guess. They successfully completed the DuckDuckHack Goodie tutorial anyway.'), + 'duckduckhack uniphil' => test_zci('uniphil is awesome and has successfully completed the DuckDuckHack Goodie tutorial!'), 'duckduckhack uniphil is awesome' => undef, );