From ff8a4f6f76ed56042cca4cab463fa3e753a06730 Mon Sep 17 00:00:00 2001
From: Lars Mueller <appgurulars@gmx.de>
Date: Wed, 26 May 2021 10:33:34 +0200
Subject: [PATCH] Lua log file: Fix infinite recursion

---
 persistence.lua | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/persistence.lua b/persistence.lua
index 08d1204..46c4c0b 100644
--- a/persistence.lua
+++ b/persistence.lua
@@ -87,6 +87,10 @@ function lua_log_file:_dump(value, is_key)
 	reference = self.reference_count + 1
 	local key = "R[" .. reference .."]"
 	local formatted
+	local function create_reference()
+		self.reference_count = reference
+		self.references[value] = reference
+	end
 	if _type == "string" then
 		if is_key and value:len() <= key:len() and value:match"[%a_][%a%d_]*" then
 			-- Short key
@@ -97,7 +101,11 @@ function lua_log_file:_dump(value, is_key)
 			-- Short string
 			return formatted
 		end
+		-- Use reference
+		create_reference()
 	elseif _type == "table" then
+		-- Tables always need a reference before they are traversed to prevent infinite recursion
+		create_reference()
 		local entries = {}
 		for _, value in ipairs(value) do
 			table.insert(entries, self:_dump(value))
@@ -113,8 +121,6 @@ function lua_log_file:_dump(value, is_key)
 	else
 		error("unsupported type: " .. _type)
 	end
-	self.reference_count = reference
-	self.references[value] = reference
 	self:log(key .. "=" .. formatted)
 	return key
 end