From 4ea4a808f06d49688d75ab1fe0ca4694ffd442af Mon Sep 17 00:00:00 2001 From: Thomas Rudin Date: Fri, 2 Nov 2018 11:55:41 +0100 Subject: [PATCH 1/3] check for buildable-to when placing not just air --- travelnet.lua | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/travelnet.lua b/travelnet.lua index aee7f64..9300a3b 100644 --- a/travelnet.lua +++ b/travelnet.lua @@ -81,7 +81,8 @@ minetest.register_node("travelnet:travelnet", { on_place = function(itemstack, placer, pointed_thing) local pos = pointed_thing.above; - if( minetest.get_node({x=pos.x, y=pos.y+1, z=pos.z}).name ~= "air" ) then + local node_name = minetest.get_node({x=pos.x, y=pos.y+1, z=pos.z}).name + if( not node_name or not minetest.registered_nodes[node_name].buildable_to ) then minetest.chat_send_player( placer:get_player_name(), S('Not enough vertical space to place the travelnet box!')) return; From 1e7506f03884506136b6a1e400e467b5435d4722 Mon Sep 17 00:00:00 2001 From: HybridDog Date: Tue, 6 Nov 2018 08:33:24 +0100 Subject: [PATCH 2/3] pull request fixes Co-Authored-By: thomasrudin --- travelnet.lua | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/travelnet.lua b/travelnet.lua index 9300a3b..4870279 100644 --- a/travelnet.lua +++ b/travelnet.lua @@ -82,7 +82,9 @@ minetest.register_node("travelnet:travelnet", { local pos = pointed_thing.above; local node_name = minetest.get_node({x=pos.x, y=pos.y+1, z=pos.z}).name - if( not node_name or not minetest.registered_nodes[node_name].buildable_to ) then + local def = minetest.registered_nodes[ + minetest.get_node({x=pos.x, y=pos.y+1, z=pos.z}).name] + if not def or not def.buildable_to then minetest.chat_send_player( placer:get_player_name(), S('Not enough vertical space to place the travelnet box!')) return; From e4565899e4bde79199f2a0816fb8b2a44e04ba6e Mon Sep 17 00:00:00 2001 From: Thomas Rudin Date: Tue, 6 Nov 2018 08:35:16 +0100 Subject: [PATCH 3/3] cleanup unneeded var --- travelnet.lua | 1 - 1 file changed, 1 deletion(-) diff --git a/travelnet.lua b/travelnet.lua index 4870279..34e3186 100644 --- a/travelnet.lua +++ b/travelnet.lua @@ -81,7 +81,6 @@ minetest.register_node("travelnet:travelnet", { on_place = function(itemstack, placer, pointed_thing) local pos = pointed_thing.above; - local node_name = minetest.get_node({x=pos.x, y=pos.y+1, z=pos.z}).name local def = minetest.registered_nodes[ minetest.get_node({x=pos.x, y=pos.y+1, z=pos.z}).name] if not def or not def.buildable_to then