From 02ddbbd85883d64fd07da5b54a69b9f2db4dfa52 Mon Sep 17 00:00:00 2001 From: Jacob Gustafson <7557867+poikilos@users.noreply.github.com> Date: Mon, 24 Sep 2018 20:37:44 -0400 Subject: [PATCH 1/5] consolidate forks and credits sections --- README.md | 60 ++++++++++++++++++++++++++++++++++--------------------- 1 file changed, 37 insertions(+), 23 deletions(-) diff --git a/README.md b/README.md index 85b12cf..200a599 100644 --- a/README.md +++ b/README.md @@ -1,19 +1,30 @@ +# compassgps This mod creates a customizable compass with user settable bookmarks and shared and admin bookmarks in multiplayer. **Compass GPS version 2.7 fork 1** +(Kilarin's fork) -Echo created a compass mod back in 2012: [https://forum.minetest.net/viewtopic.php?id=3785](https://forum.minetest.net/viewtopic.php?id=3785)

-PilzAdams made a modification of it, which I can not find the source to, I don't know how much of PilzAdams changes made it into the later versions of Echo's mod.

-Then in 2013 TeTpaAka made a fork of the compass mod that he called compass+ [https://forum.minetest.net/viewtopic.php?id=8117](https://forum.minetest.net/viewtopic.php?id=8117)

-This fork added the ability to "bookmark" specific places, and a gui so you could choose what point the compass should point to. -This is my fork of TeTpaAka's fork of Echo's mod. :) +TeTpaAka's gui, file io, and coding for multiplayer games was simply amazing. But as I was learning from their awesome code, I saw some changes I'd like to make using these new ideas, as well as some things I learned while looking at other mods. So, with complete and total respect for the original awesome mods, and hopefully in the same spirit as theirs, I present my own fork of the fork. CompassGPS -The compass mod as it was is REALLY cool I love the way Echo managed to make the compass in your inventory actually change it's image to point in the direction of it's target + +## Previous Forks +Echo created a compass mod back in 2012: [https://forum.minetest.net/viewtopic.php?id=3785](https://forum.minetest.net/viewtopic.php?id=3785) +* Echo managed to make the compass in your inventory actually change it's image to point in the direction of it's target. +PilzAdams' fork was lost, and the amount of code that merged back into Echo's is unknown.
+TeTpaAka (2013) made a fork of the compass mod called compass+ [https://forum.minetest.net/viewtopic.php?id=8117](https://forum.minetest.net/viewtopic.php?id=8117) +* added bookmarks via chat commands +* added some type of GUI, file IO, and multiplayer considerations +Kilarin's fork added the ability to bookmark specific places, and a gui so you could choose what point the compass should point to: +* this fork was renamed CompassGPS +* fixed a few bugs while I was working on this. There was a problem in the mod that caused compass to jump around in inventory if there were empty slots above it, that is fixed now. And there was also a problem with the bookmark list not being saved after you removed a bookmark if you didn't add a new bookmark afterwards. Now the bookmark list is saved whenever you change it, either adding or removing. +* tried to follow Echo and TeTpaAka's examples of how to properly code for multiplayer games, and all of the new settings should work just fine in a multiplayer game. +* shared and admin bookmarks +* made maps based on TeTpaAka's code +* see changelog for later changes ![alt text](http://i59.tinypic.com/a15ls0.png "image") -And TeTpaAka's gui, file io, and coding for multiplayer games was simply amazing. But as I was learning from their awesome code, I saw some changes I'd like to make using these new ideas, as well as some things I learned while looking at other mods. So, with complete and total respect for the original awesome mods, and hopefully in the same spirit as theirs, I present my own fork of the fork. CompassGPS The crafting recipe for a compass is unchanged:

``` @@ -29,7 +40,7 @@ Compass GPS introduces several other changes though. First of all, this mod add The hud updates constantly as long as the compass is in one of your active inventory slots, so you can always know where you are in relation to the target node, and how far away it is. -There is a GUI that pops up whenever you wield the compass and left click. I never played with a GUI in minetest before, so this was a new experience for me, I learned a lot and made quite a few changes: +There is a GUI that pops up whenever you wield the compass and left click. I never played with a GUI in minetest before, so this was a new experience for me, I learned a lot and made quite a few changes -Kilarin: ![alt text](http://i61.tinypic.com/29zzgy1.png "image") @@ -48,7 +59,7 @@ If you click the "Settings" button in the upper right hand corner it brings up a ![alt text](http://i59.tinypic.com/aahqa8.png "image")

(The two awesome new compass images are by Bas080 and Spootonium) -I figured the position of the hud text was likely to be something that people would want to customize, so here in the settings gui are the x and y coords for the hud text. Just enter the new coords where you want the hud text to appear and click "Change Hud"

+In the settings gui are the x and y coords to customize the position of the hud text. Just enter the new coords where you want the hud text to appear and click "Change Hud"

The cords must be between 0 and 1 and represent a percentage of the screen, so x=0 would put the text at the far left of the screen, and y=0.98 would put the text almost at the bottom of the screen. The default is x=0.4 and y=0.01, and that is displayed right over the input boxes so the user can easily set them back to the default if they are having trouble placing the hud. If you change either the x or y coord to a number that is out of range (less than 0 or greater than 1) then the hud will not be displayed. That makes it easy to turn the hud off if you wish.

You can also change the color of the hud text by changing the value in the "Color" field here. Again, click "Change Hud" to make the update appear. @@ -70,9 +81,6 @@ set_bookmark

find_bookmark

remove_bookmark -I also fixed a few bugs while I was working on this. There was a problem in the mod that caused compass to jump around in inventory if there were empty slots above it, that is fixed now. And there was also a problem with the bookmark list not being saved after you removed a bookmark if you didn't add a new bookmark afterwards. Now the bookmark list is saved whenever you change it, either adding or removing. - -I tried to follow Echo and TeTpaAka's examples of how to properly code for multiplayer games, and all of the new settings should work just fine in a multiplayer game. ----** MAPS! **---- @@ -101,15 +109,21 @@ Thanks to some nice code by Miner59 you can now mount a map on a wall! If you c The code is kinda a mess, because I was learning a lot of new things while working on it. I hope to do a clean up on it sometime in the near future, but I wanted to release it now so some people could start testing it. Please do not hesitate to offer critiques, criticism, or coding advice. I'm new to lua and minetest and could use the help. -And above all, if you run into a bug, please let me know! +Please report bugs to the maintainer, which for the Kilarin fork can be done at: -**Credits:**

-Original mod is by Echo and TeTpaAka, and probably PilzAdam. Cactuz_pl clockmod showed me how to write the hud to the screen. My son offered a lot of advice and suggested several changes. I got an example of how to sort lists in lua from Michal Kottman on StackOverflow. Big thanks to Bas080 and spootonium for providing some very nice alternate images for the compass gps mod! Also thanks to Topywo for the shared bookmarks idea, and to my son for several ideas, corrections, and testing help.

-Map idea, image, and initial code by TeTpaAka. Store current position in map code contributed by Miner95

-intllib support by TeTpaAka

-Wall mounted maps by Miner59 +## Credits +Kilarin's fork: +* Original mod is by Echo and TeTpaAka, and probably PilzAdam (see Previous Forks above for details). +* write hud to screen: based on Cactuz_pl clockmod +* Kilarin credits his son who offered a lot of advice and testing, and suggested several changes and corrections. +* sort lists in lua: Michal Kottman on StackOverflow +* Big thanks to Bas080 and spootonium for providing some very nice alternate images for the compass gps mod! +* Also thanks to Topywo for the shared bookmarks idea +* Map idea, image, and initial code by TeTpaAka. Store current position in map code contributed by Miner95

+* intllib support by TeTpaAka +* Wall mounted maps by Miner59 -**License:**

+## License Original code by Echo, PilzAdam, and TeTpaAka is WTFPL. My changes are CC0 (No rights reserved)

textures: original compass textures: CC BY-SA by Echo

compass b textures: CC BY-SA by Bas080 (slight modifications by Kilarin)

@@ -117,17 +131,17 @@ textures: original compass textures: CC BY-SA by Echo

(slight modifications by Kilarin)

map texture: CC BY-SA by TeTpaAka (slight modifications by Kilarin for blank map) -**Dependencies:**

+## Dependencies default is the only requirement.

PilzAdams Beds mod and the sethome-mod are supported if you have them. -**Incompatibilities:**

+## Incompatibilities This mod will clash with both the original compass and compass+ mods. They should not be installed and enabled at the same time as compassgps. HOWEVER, compassgps is 100% compatible with the bookmarks file from the compass+ mod. So if you were using compass+ and switch to compassgps you will NOT lose your previous bookmarks. -**github source:**

+## GitHub source [https://github.com/Kilarin/compassgps](https://github.com/Kilarin/compassgps) -**Download:**

+## Download [https://github.com/Kilarin/compassgps/archive/master.zip](https://github.com/Kilarin/compassgps/archive/master.zip) **To install:**

From 9b852c260ce29b64e75998870d271d0c47d70d22 Mon Sep 17 00:00:00 2001 From: Jacob Gustafson <7557867+poikilos@users.noreply.github.com> Date: Mon, 24 Sep 2018 20:48:19 -0400 Subject: [PATCH 2/5] improved formatting --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 200a599..cb5822b 100644 --- a/README.md +++ b/README.md @@ -9,13 +9,13 @@ TeTpaAka's gui, file io, and coding for multiplayer games was simply amazing. B ## Previous Forks -Echo created a compass mod back in 2012: [https://forum.minetest.net/viewtopic.php?id=3785](https://forum.minetest.net/viewtopic.php?id=3785) +**Echo** created a compass mod back in 2012: [https://forum.minetest.net/viewtopic.php?id=3785](https://forum.minetest.net/viewtopic.php?id=3785) * Echo managed to make the compass in your inventory actually change it's image to point in the direction of it's target. -PilzAdams' fork was lost, and the amount of code that merged back into Echo's is unknown.
-TeTpaAka (2013) made a fork of the compass mod called compass+ [https://forum.minetest.net/viewtopic.php?id=8117](https://forum.minetest.net/viewtopic.php?id=8117) +**PilzAdam**'s fork was lost, and the amount of code that merged back into Echo's is unknown.
+**TeTpaAka** (2013) made a fork of the compass mod called compass+ [https://forum.minetest.net/viewtopic.php?id=8117](https://forum.minetest.net/viewtopic.php?id=8117) * added bookmarks via chat commands * added some type of GUI, file IO, and multiplayer considerations -Kilarin's fork added the ability to bookmark specific places, and a gui so you could choose what point the compass should point to: +**Kilarin**'s fork added the ability to bookmark specific places, and a gui so you could choose what point the compass should point to: * this fork was renamed CompassGPS * fixed a few bugs while I was working on this. There was a problem in the mod that caused compass to jump around in inventory if there were empty slots above it, that is fixed now. And there was also a problem with the bookmark list not being saved after you removed a bookmark if you didn't add a new bookmark afterwards. Now the bookmark list is saved whenever you change it, either adding or removing. * tried to follow Echo and TeTpaAka's examples of how to properly code for multiplayer games, and all of the new settings should work just fine in a multiplayer game. From 1f8f86b804a9cd18767180e06b5c449de580cb9a Mon Sep 17 00:00:00 2001 From: Jacob Gustafson <7557867+poikilos@users.noreply.github.com> Date: Mon, 24 Sep 2018 20:49:17 -0400 Subject: [PATCH 3/5] fix use of markdown --- README.md | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index cb5822b..1e33bc9 100644 --- a/README.md +++ b/README.md @@ -9,13 +9,17 @@ TeTpaAka's gui, file io, and coding for multiplayer games was simply amazing. B ## Previous Forks -**Echo** created a compass mod back in 2012: [https://forum.minetest.net/viewtopic.php?id=3785](https://forum.minetest.net/viewtopic.php?id=3785) +### Echo +created a compass mod back in 2012: [https://forum.minetest.net/viewtopic.php?id=3785](https://forum.minetest.net/viewtopic.php?id=3785) * Echo managed to make the compass in your inventory actually change it's image to point in the direction of it's target. -**PilzAdam**'s fork was lost, and the amount of code that merged back into Echo's is unknown.
-**TeTpaAka** (2013) made a fork of the compass mod called compass+ [https://forum.minetest.net/viewtopic.php?id=8117](https://forum.minetest.net/viewtopic.php?id=8117) +### PilzAdam +fork was lost, and the amount of code that merged back into Echo's is unknown.
+### TeTpaAka +(2013) made a fork of the compass mod called compass+ [https://forum.minetest.net/viewtopic.php?id=8117](https://forum.minetest.net/viewtopic.php?id=8117) * added bookmarks via chat commands * added some type of GUI, file IO, and multiplayer considerations -**Kilarin**'s fork added the ability to bookmark specific places, and a gui so you could choose what point the compass should point to: +### Kilarin +fork added the ability to bookmark specific places, and a gui so you could choose what point the compass should point to: * this fork was renamed CompassGPS * fixed a few bugs while I was working on this. There was a problem in the mod that caused compass to jump around in inventory if there were empty slots above it, that is fixed now. And there was also a problem with the bookmark list not being saved after you removed a bookmark if you didn't add a new bookmark afterwards. Now the bookmark list is saved whenever you change it, either adding or removing. * tried to follow Echo and TeTpaAka's examples of how to properly code for multiplayer games, and all of the new settings should work just fine in a multiplayer game. From 6f09d5d2a20c80b005fd4c4cb146d2da1b68929a Mon Sep 17 00:00:00 2001 From: Jacob Gustafson <7557867+poikilos@users.noreply.github.com> Date: Mon, 24 Sep 2018 21:00:51 -0400 Subject: [PATCH 4/5] improve use of markdown --- README.md | 35 +++++++++++++++-------------------- 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/README.md b/README.md index 1e33bc9..1b3294b 100644 --- a/README.md +++ b/README.md @@ -1,31 +1,26 @@ # compassgps This mod creates a customizable compass with user settable bookmarks and shared and admin bookmarks in multiplayer. -**Compass GPS version 2.7 fork 1** -(Kilarin's fork) +**Compass GPS version 2.7 fork 1** (Kilarin's fork) TeTpaAka's gui, file io, and coding for multiplayer games was simply amazing. But as I was learning from their awesome code, I saw some changes I'd like to make using these new ideas, as well as some things I learned while looking at other mods. So, with complete and total respect for the original awesome mods, and hopefully in the same spirit as theirs, I present my own fork of the fork. CompassGPS -## Previous Forks -### Echo -created a compass mod back in 2012: [https://forum.minetest.net/viewtopic.php?id=3785](https://forum.minetest.net/viewtopic.php?id=3785) -* Echo managed to make the compass in your inventory actually change it's image to point in the direction of it's target. -### PilzAdam -fork was lost, and the amount of code that merged back into Echo's is unknown.
-### TeTpaAka -(2013) made a fork of the compass mod called compass+ [https://forum.minetest.net/viewtopic.php?id=8117](https://forum.minetest.net/viewtopic.php?id=8117) -* added bookmarks via chat commands -* added some type of GUI, file IO, and multiplayer considerations -### Kilarin -fork added the ability to bookmark specific places, and a gui so you could choose what point the compass should point to: -* this fork was renamed CompassGPS -* fixed a few bugs while I was working on this. There was a problem in the mod that caused compass to jump around in inventory if there were empty slots above it, that is fixed now. And there was also a problem with the bookmark list not being saved after you removed a bookmark if you didn't add a new bookmark afterwards. Now the bookmark list is saved whenever you change it, either adding or removing. -* tried to follow Echo and TeTpaAka's examples of how to properly code for multiplayer games, and all of the new settings should work just fine in a multiplayer game. -* shared and admin bookmarks -* made maps based on TeTpaAka's code -* see changelog for later changes +**Previous Forks**
+* Echo created a compass mod back in 2012: [https://forum.minetest.net/viewtopic.php?id=3785](https://forum.minetest.net/viewtopic.php?id=3785) + * Echo managed to make the compass in your inventory actually change it's image to point in the direction of it's target. +* PilzAdam's fork was lost, and the amount of code that merged back into Echo's is unknown.
+* TeTpaAka made a fork (2013) of the compass mod called compass+ [https://forum.minetest.net/viewtopic.php?id=8117](https://forum.minetest.net/viewtopic.php?id=8117) + * added bookmarks via chat commands + * added some type of GUI, file IO, and multiplayer considerations +* Kilarin fork adds the ability to bookmark named targets, and a GUI so you could choose the compass' target: + * this fork was renamed CompassGPS + * fixed a few bugs while I was working on this. There was a problem in the mod that caused compass to jump around in inventory if there were empty slots above it, that is fixed now. And there was also a problem with the bookmark list not being saved after you removed a bookmark if you didn't add a new bookmark afterwards. Now the bookmark list is saved whenever you change it, either adding or removing. + * tried to follow Echo and TeTpaAka's examples of how to properly code for multiplayer games, and all of the new settings should work just fine in a multiplayer game. + * shared and admin bookmarks + * made maps based on TeTpaAka's code + * see changelog for later changes ![alt text](http://i59.tinypic.com/a15ls0.png "image") From fe9d204ef261d4d30da9584a461802805b4aa334 Mon Sep 17 00:00:00 2001 From: Jacob Gustafson <7557867+poikilos@users.noreply.github.com> Date: Mon, 24 Sep 2018 21:01:23 -0400 Subject: [PATCH 5/5] more is exciting --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 1b3294b..d33769b 100644 --- a/README.md +++ b/README.md @@ -20,7 +20,7 @@ TeTpaAka's gui, file io, and coding for multiplayer games was simply amazing. B * tried to follow Echo and TeTpaAka's examples of how to properly code for multiplayer games, and all of the new settings should work just fine in a multiplayer game. * shared and admin bookmarks * made maps based on TeTpaAka's code - * see changelog for later changes + * see changelog for more! ![alt text](http://i59.tinypic.com/a15ls0.png "image")