From 201090592c613a48633215721b14b6f4d0243cd1 Mon Sep 17 00:00:00 2001 From: Rubenwardy Date: Sat, 25 Aug 2012 12:26:03 +0100 Subject: [PATCH] Did some BBCode formating, and fixed security issue --- mm/getmodbyid.php | 8 ++++++-- scripts/formatcode.php | 29 +++++++++++++++++++++++++++++ viewmod.php | 5 +++-- 3 files changed, 38 insertions(+), 4 deletions(-) create mode 100644 scripts/formatcode.php diff --git a/mm/getmodbyid.php b/mm/getmodbyid.php index d4097f9..f9ee564 100644 --- a/mm/getmodbyid.php +++ b/mm/getmodbyid.php @@ -2,8 +2,12 @@ include "../scripts/setup.php"; $id=$_GET['id']; -$id= mysql_real_escape_string ($id); -$res = mysql_query("SELECT * FROM mods WHERE mod_id='$id'",$handle) or SQLerror("MySQL Query Error","Error on searching database.mods.mod_id for '$id'"); + +if (is_numeric($id)==false){ + SQLerror("error: Non Numeric Value","?id=$id is not allowed"); +} + +$res = mysql_query("SELECT * FROM mods WHERE mod_id=$id",$handle) or SQLerror("MySQL Query Error","Error on searching database.mods.mod_id for '$id'"); $row = mysql_fetch_row($res) or die("row error"); header("Content-type: text/plain"); diff --git a/scripts/formatcode.php b/scripts/formatcode.php new file mode 100644 index 0000000..d080652 --- /dev/null +++ b/scripts/formatcode.php @@ -0,0 +1,29 @@ +",$result); +$result=str_replace("[/img-enforce]","\" width=\"900\"/>",$result); + +$result=str_replace("[url=","",$result); +$result=str_replace("[/url]","",$result); + +$result=str_replace("\n","
",$result); + +$result=str_replace("[h]","

",$result); +$result=str_replace("[/h]","

",$result); + +$result=str_replace("[b]","",$result); +$result=str_replace("[/b]","",$result); + +$result=str_replace("[u]","",$result); +$result=str_replace("[/u]","",$result); + +$result=str_replace("[i]","",$result); +$result=str_replace("[/i]","",$result); + +return $result; +} +?> \ No newline at end of file diff --git a/viewmod.php b/viewmod.php index 3639009..e444707 100644 --- a/viewmod.php +++ b/viewmod.php @@ -12,11 +12,12 @@ $row = mysql_fetch_row($res) or die("row error"); $page_title="View mod - {$row[1]}"; include "scripts/pageheader.php"; +include "scripts/formatcode.php"; -echo "
"; +echo ""; echo ""; -echo ""; +echo ""; include "scripts/loadposts.php"; ?>
Download"; echo "

{$row[1]} - by {$row[3]}

{$row[2]}
{$row[4]}
".formatbb($row[4])."