From e395bee5f6240d9e69ac475c15e1e453feb0b470 Mon Sep 17 00:00:00 2001
From: addi <addi@king-arthur.eu>
Date: Wed, 20 Jul 2016 08:58:53 +0200
Subject: [PATCH] Better nodebox, centered and two-sided display

---
 mod_files/signs.lua        |  63 +++++++++++++++++++++++++++++++------
 textures/medieval_sign.png | Bin 0 -> 607 bytes
 2 files changed, 53 insertions(+), 10 deletions(-)
 create mode 100644 textures/medieval_sign.png

diff --git a/mod_files/signs.lua b/mod_files/signs.lua
index bff051b..d448bf2 100644
--- a/mod_files/signs.lua
+++ b/mod_files/signs.lua
@@ -16,6 +16,24 @@ local facedir = {
 	[0] = {x=0, y=0, z=1}, {x=1, y=0, z=0}, {x=0, y=0, z=-1}, {x=-1, y=0, z=0}
 }
 
+-- Works good for the most items, but not for all
+local function get_drawtype(itemstring)
+	local def = minetest.registered_items[itemstring]
+	local drawtype = def.drawtype
+	local wield_image = def.wield_image
+	--minetest.debug(string.format("Item: %s dt: %s, wield: %s", itemstring, dump(drawtype),dump(wield_image)))
+	if wield_image ~= "" then
+		return "twosided"
+	elseif drawtype == "normal" or 
+		   drawtype == "mesh" or 
+		   drawtype == "nodebox" then
+		return "centered"
+	else 
+		return "twosided"
+	end
+end
+
+local PI = math.pi
 local function update_item(pos, node)
 	remove_item(pos, node)
 	local meta = minetest.get_meta(pos)
@@ -24,12 +42,30 @@ local function update_item(pos, node)
 	local posad = facedir[node.param2]
 	if not posad or itemstring == "" then return end
 
-	pos = vector.add(pos, vector.multiply(posad, 6.5/16))
+	local yaw = PI*2 - node.param2 * PI/2
+	if get_drawtype(itemstring) == "centered" then
+		local pos = pos
+		local obj = minetest.add_entity(pos, "medieval:sign_item")
+		obj:setyaw(yaw)
+		obj:get_luaentity():init(itemstring)
+	elseif get_drawtype(itemstring)=="twosided" then
+		-- Front
+		local pos1 = vector.add(pos, vector.multiply(posad, -1/16) )
+		local obj1 = minetest.add_entity(pos1, "medieval:sign_item")
+		obj1:setyaw(yaw)
+		obj1:get_luaentity():init(itemstring)
+		
+		-- Back
+		local pos2 = vector.add(pos, vector.multiply(posad, 1/16) )
+		local obj2 = minetest.add_entity(pos2, "medieval:sign_item")
+		obj2:setyaw(yaw+PI) --rotate this about 180 Degrees
+		obj2:get_luaentity():init(itemstring)
+	else
+		minetest.log("error", "Error: Invalid drawtype of "..itemstring)
+	end
+	pos = vector.add(pos, vector.multiply(posad, -1/16) )
+
 
-	local obj = minetest.add_entity(pos, "medieval:sign_item")
-	local yaw = math.pi*2 - node.param2 * math.pi/2
-	obj:setyaw(yaw)
-	obj:get_luaentity():init(itemstring)
 end
 
 local formspec = [[
@@ -91,12 +127,19 @@ minetest.register_node("medieval:sign", {
 	paramtype2 = "facedir",
 	inventory_image = "default_sign_wood.png",
 	node_box = {
-		 type = "fixed",
-		 fixed = {-0.4375, -0.3125, 0.4375, 0.4375, 0.3125, 0.5},
+		type = "fixed",
+		fixed = {
+			{-0.4375, -0.375, -0.0625, 0.4375, 0.375, 0.0625}, -- NodeBox4
+			{-0.375, -0.4375, -0.0625, 0.375, -0.375, 0.0625}, -- NodeBox5
+			{-0.3125, 0.375, 0, -0.1875, 0.5, 0}, -- NodeBox6
+			{0.1875, 0.375, 0, 0.3125, 0.5, 0}, -- NodeBox7
+			{0.25, 0.375, -0.0625, 0.25, 0.5, 0.0625}, -- NodeBox8
+			{-0.25, 0.375, -0.0625, -0.25, 0.5, 0.0625}, -- NodeBox9
+		}
 	},
-	tiles = {"default_sign_wall_wood.png"},
-	inventory_image = "default_sign_wood.png",
-	wield_image = "default_sign_wood.png",
+	tiles = {"medieval_sign.png"},
+	inventory_image = "medieval_sign.png",
+	wield_image = "medieval_sign.png",
 	after_place_node = itemsign.after_place,
 	on_construct = itemsign.construct,
 	on_metadata_inventory_put = itemsign.inventory_modified,
diff --git a/textures/medieval_sign.png b/textures/medieval_sign.png
new file mode 100644
index 0000000000000000000000000000000000000000..7f2d48778217c8ad41a0f87048ee70e6aa71b5b8
GIT binary patch
literal 607
zcmV-l0-*hgP)<h;3K|Lk000e1NJLTq000mG000mO1^@s6AM^iV00009a7bBm000XU
z000XU0RWnu7ytkO2XskIMF-#q5)&sE)z;Xp0000PbVXQnLvL+uWo~o;Lvm$dbY)~9
zcWHEJAV*0}P*;Ht7XSbO*-1n}R5;76lFx6`Fcil>j-8}w`ipKF2pAykz&`-oIHB@4
zbL9q{I3R9Fn^0SXy0&T8#7P{RL)K*Nv>WeYJ-_$;*na-PQA{Qi_fURZ1MrTUd%fO+
zd6s4OAOhgSo9Fk)`!J?0DJ2f}K7XGI1t2|-SI<UNWlq%TAVuByXb`m^Ygr^3>uT}k
zbX`LMoU{D;z2s~hlNP!W{Y^6ZamaR;*N`%&7y0;Mgmd<A24~|K0BZ_H-2iI}Oqp{z
zU6N)6X;z^85N&FS5MFx&=}AmkpQ8Mbby}cHSZ_5#2%enunr98-us-=VR{&*IF~2sq
zchMAOMQJKbWih5=u}V?WBM21xnFYRT0lt*He|yeqlQCOt0Z4U;&JCSVH8bgUe4>s|
zrZwvu(*mq>%$7U0yPRcm1Hd*d2z*Ii77ak>5)!z0`IuyP=NCL7h?GY(jF334<_W_%
zq^J%(A(i4}6d&v<fGjtB`#G<hq@XaC8(phSWl_?@SCYy?`X?a_)FGhPRSfP}RtkaV
zL8eOpo}Tub+TL7We#}}x6#BeAAG6wIO=IO8*4FFwMl<S%oDRE<EBB5Rd%?$dFC0K#
tm<AFCs`+p09M;y)0l}xQSAzc${{U(T+OAQ1qbvXb002ovPDHLkV1m&@|E2%{

literal 0
HcmV?d00001