From 6344997fad69b82881cf83d24a41b5573bd71c72 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Mon, 27 Nov 2017 14:31:52 +0100 Subject: [PATCH] Don't forcibly enable immediate XFB in game INIs Forcing people to use hacks is a bad idea in general, and there are two practical problems with doing it for immediate XFB in particular: 1. It breaks the GC IPL, which some users run when launching games. 2. Competitive players don't necessarily want the lowest possible latency - they might want the latency that's the closest to console, so if they're playing locally with a low-latency monitor, they might not want to use immediate XFB. (This isn't a theoretical concern - I've seen Melee players want to increase their latency.) Besides, it feels arbitrary that just these five specific games should have immediate XFB forced on. --- Data/Sys/GameSettings/GAL.ini | 3 --- Data/Sys/GameSettings/GP5.ini | 3 --- Data/Sys/GameSettings/RF7.ini | 3 --- Data/Sys/GameSettings/RSB.ini | 3 --- Data/Sys/GameSettings/STK.ini | 3 --- 5 files changed, 15 deletions(-) diff --git a/Data/Sys/GameSettings/GAL.ini b/Data/Sys/GameSettings/GAL.ini index 98c71287c8..5937932868 100644 --- a/Data/Sys/GameSettings/GAL.ini +++ b/Data/Sys/GameSettings/GAL.ini @@ -19,6 +19,3 @@ EmulationIssues = [Video_Stereoscopy] StereoConvergence = 64 - -[Video_Hacks] -ImmediateXFBEnable = True diff --git a/Data/Sys/GameSettings/GP5.ini b/Data/Sys/GameSettings/GP5.ini index 1ac01528b6..c65ba366b0 100644 --- a/Data/Sys/GameSettings/GP5.ini +++ b/Data/Sys/GameSettings/GP5.ini @@ -19,6 +19,3 @@ EmulationIssues = [Video_Hacks] EFBToTextureEnable = False - -[Video_Hacks] -ImmediateXFBEnable = True diff --git a/Data/Sys/GameSettings/RF7.ini b/Data/Sys/GameSettings/RF7.ini index cc9569746b..0a3dd15e7f 100644 --- a/Data/Sys/GameSettings/RF7.ini +++ b/Data/Sys/GameSettings/RF7.ini @@ -16,6 +16,3 @@ EmulationIssues = [ActionReplay] # Add action replay cheats here. - -[Video_Hacks] -ImmediateXFBEnable = True diff --git a/Data/Sys/GameSettings/RSB.ini b/Data/Sys/GameSettings/RSB.ini index f283352c23..783cc4770b 100644 --- a/Data/Sys/GameSettings/RSB.ini +++ b/Data/Sys/GameSettings/RSB.ini @@ -19,6 +19,3 @@ EmulationIssues = Classic mode score report needs real xfb. Nes masterpieces and [Video_Stereoscopy] StereoConvergence = 136 - -[Video_Hacks] -ImmediateXFBEnable = True diff --git a/Data/Sys/GameSettings/STK.ini b/Data/Sys/GameSettings/STK.ini index 0327877dfa..9628eb1063 100644 --- a/Data/Sys/GameSettings/STK.ini +++ b/Data/Sys/GameSettings/STK.ini @@ -16,6 +16,3 @@ EmulationStateId = 5 [ActionReplay] # Add action replay cheats here. - -[Video_Hacks] -ImmediateXFBEnable = True