From b0d1d6084caf47f1e989eff5ad01e8ac1afee608 Mon Sep 17 00:00:00 2001 From: Gabriel Scherer Date: Tue, 29 Oct 2019 12:44:12 +0100 Subject: [PATCH] Makefile: install all compiler-libs archives instead of a manual listing The issue #9050 comes (partly) from #2281 forgetting to add the compilerlibs/ocamlmiddleend archives in the installation target. The present patch should solve this issue once and for all, by using a wildcard to install all archives that have been built in compilerlibs/, instead of using a manual listing. Compared to trunk, the following extra files are installed in $(LIBDIR)/compilerlibs: ocamlmiddleend.{a,cma,cmxa}. There are no other changes in the installed-files list. --- Changes | 3 +++ Makefile | 16 ++++++++-------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/Changes b/Changes index aae6ee912..21d93c41c 100644 --- a/Changes +++ b/Changes @@ -471,6 +471,9 @@ OCaml 4.09 maintenance branch: - #8965, #8979: Alpine build failure caused by check-parser-uptodate-or-warn.sh (Gabriel Scherer and David Allsopp, report by Anton Kochkov) +- #9050, #9076: install missing compilerlibs/ocamlmiddleend archives + (Gabriel Scherer, review by Florian Angeletti, report by Olaf Hering) + OCaml 4.09.0 (19 September 2019): --------------------------------- diff --git a/Makefile b/Makefile index b92699d3b..802196d1e 100644 --- a/Makefile +++ b/Makefile @@ -585,8 +585,10 @@ ifeq "$(INSTALL_SOURCE_ARTIFACTS)" "true" "$(INSTALL_COMPLIBDIR)" endif $(INSTALL_DATA) \ - compilerlibs/ocamlcommon.cma compilerlibs/ocamlbytecomp.cma \ - compilerlibs/ocamltoplevel.cma $(BYTESTART) $(TOPLEVELSTART) \ + compilerlibs/*.cma \ + "$(INSTALL_COMPLIBDIR)" + $(INSTALL_DATA) \ + $(BYTESTART) $(TOPLEVELSTART) \ "$(INSTALL_COMPLIBDIR)" $(INSTALL_PROG) expunge "$(INSTALL_LIBDIR)/expunge$(EXE)" $(INSTALL_DATA) \ @@ -686,7 +688,7 @@ ifeq "$(INSTALL_SOURCE_ARTIFACTS)" "true" "$(INSTALL_COMPLIBDIR)" endif $(INSTALL_DATA) \ - compilerlibs/ocamloptcomp.cma $(OPTSTART) \ + $(OPTSTART) \ "$(INSTALL_COMPLIBDIR)" ifneq "$(WITH_OCAMLDOC)" "" $(MAKE) -C ocamldoc installopt @@ -731,9 +733,9 @@ installoptopt: asmcomp/debug/*.cmx \ "$(INSTALL_COMPLIBDIR)" $(INSTALL_DATA) \ - compilerlibs/ocamlcommon.cmxa compilerlibs/ocamlcommon.$(A) \ - compilerlibs/ocamlbytecomp.cmxa compilerlibs/ocamlbytecomp.$(A) \ - compilerlibs/ocamloptcomp.cmxa compilerlibs/ocamloptcomp.$(A) \ + compilerlibs/*.cmxa compilerlibs/*.$(A) \ + "$(INSTALL_COMPLIBDIR)" + $(INSTALL_DATA) \ $(BYTESTART:.cmo=.cmx) $(BYTESTART:.cmo=.$(O)) \ $(OPTSTART:.cmo=.cmx) $(OPTSTART:.cmo=.$(O)) \ "$(INSTALL_COMPLIBDIR)" @@ -744,8 +746,6 @@ installoptopt: toplevel/opttopdirs.cmi \ "$(INSTALL_LIBDIR)"; \ $(INSTALL_DATA) \ - compilerlibs/ocamlopttoplevel.cmxa \ - compilerlibs/ocamlopttoplevel.$(A) \ $(OPTTOPLEVELSTART:.cmo=.cmx) $(OPTTOPLEVELSTART:.cmo=.$(O)) \ "$(INSTALL_COMPLIBDIR)"; \ fi